Skip to content

Remove default host for Plex config#26583

Merged
MartinHjelmare merged 7 commits into
home-assistant:devfrom
jjlawren:plex_config_flow_prep
Sep 11, 2019
Merged

Remove default host for Plex config#26583
MartinHjelmare merged 7 commits into
home-assistant:devfrom
jjlawren:plex_config_flow_prep

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 11, 2019

Breaking Changes:

  • Removes default value of host config parameter.
  • Requires one of host or token in the configuration.

Description:

Preparation for #26548 to avoid multiple HA releases with breaking changes in Plex.

Previous PRs for this release include #26444, #26458, #26488

Adds support for configuration by token and optionally server. If configured this way, will retrieve connection URL from Plex service. The server config option is only used if multiple Plex servers are attached to the account associated with the provided token.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10342

Example entry for configuration.yaml (if applicable):

plex:
  host: 192.168.1.10
  port: 32400
  token: MYSECRETTOKEN

or

plex:
  token: MYSECRETTOKEN
  server: 'My Plex Server Name'   # Optional if multiple servers tied to Plex account

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

@jjlawren jjlawren changed the title Remove default host, allow config with token(+server) Remove default host for Plex config Sep 11, 2019
Comment thread homeassistant/components/plex/.translations/en.json Outdated
Comment thread homeassistant/components/plex/__init__.py Outdated
Comment thread homeassistant/components/plex/__init__.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 6eeb01e into home-assistant:dev Sep 11, 2019
@jjlawren jjlawren mentioned this pull request Sep 11, 2019
6 tasks
@lock lock Bot locked and limited conversation to collaborators Sep 12, 2019
@jjlawren jjlawren deleted the plex_config_flow_prep branch October 26, 2019 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants