Skip to content

Fix Environment Canada weather forecast, retain icon_code sensor#26646

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
michaeldavie:env_canada_25
Sep 15, 2019
Merged

Fix Environment Canada weather forecast, retain icon_code sensor#26646
MartinHjelmare merged 2 commits into
home-assistant:devfrom
michaeldavie:env_canada_25

Conversation

@michaeldavie
Copy link
Copy Markdown
Contributor

@michaeldavie michaeldavie commented Sep 14, 2019

Description:

  • Bumps env_canada to 0.0.25 to address issue of weather forecasts not updating
  • Retains icon_code sensor for use with TileBoard

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10365

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare changed the title Environment Canada - Fix weather forecast, retain icon_code sensor Fix Environment Canada weather forecast, retain icon_code sensor Sep 14, 2019
@MartinHjelmare MartinHjelmare merged commit fd359c6 into home-assistant:dev Sep 15, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 16, 2019
@michaeldavie michaeldavie deleted the env_canada_25 branch September 8, 2021 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants