Skip to content

Improve bluetooth tracker device code#26067

Merged
MartinHjelmare merged 10 commits into
home-assistant:devfrom
pgilad:improve-bluetooth-tracker
Sep 12, 2019
Merged

Improve bluetooth tracker device code#26067
MartinHjelmare merged 10 commits into
home-assistant:devfrom
pgilad:improve-bluetooth-tracker

Conversation

@pgilad
Copy link
Copy Markdown
Contributor

@pgilad pgilad commented Aug 19, 2019 •
edited
Loading

Description:

Improve flow of bluetooth tracker code. This includes:

  • Load the bt_proximity module only if required
  • Extract inline functions
  • Add some typing
  • Convert devices arrays to sets
  • Introduce helper functions
  • Add several logs to help with debugging

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@homeassistant
Copy link
Copy Markdown
Contributor

homeassistant commented Aug 19, 2019

Hi @pgilad,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

pvizeli
pvizeli reviewed Aug 23, 2019
View reviewed changes
Comment thread homeassistant/components/bluetooth_tracker/device_tracker.py Outdated
MartinHjelmare
MartinHjelmare reviewed Aug 31, 2019
View reviewed changes
Comment thread homeassistant/components/bluetooth_tracker/device_tracker.py Outdated
Comment thread homeassistant/components/bluetooth_tracker/device_tracker.py Outdated
@Mariusthvdb

This comment has been minimized.

Sign in to view
@pgilad

This comment has been minimized.

Sign in to view
@Mariusthvdb

This comment has been minimized.

Sign in to view
@MartinHjelmare

This comment has been minimized.

Sign in to view
@Mariusthvdb

This comment has been minimized.

Sign in to view
@MartinHjelmare

This comment has been minimized.

Sign in to view
@pgilad
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
821846f 
…into improve-bluetooth-tracker

* 'dev' of https://github.com/home-assistant/home-assistant: (229 commits)
  New template sensor attributes (home-assistant#26127)
  Add BeeWi SmartClim BLE sensors (home-assistant#26174)
  UniFi - Simplify getting controller from config entry (home-assistant#26335)
  Inverted rflink cover (home-assistant#26038)
  Upgrade tibber library (home-assistant#26332)
  Migrate Axis, deCONZ and UniFi to use config entry subclass (home-assistant#26173)
  Upgrade sqlalchemy to 1.3.8 (home-assistant#26331)
  Change evohome to asyncio client (home-assistant#26042)
  Add support for Supla switches (home-assistant#26188)
  Add a keypress service for AlarmDecoder (home-assistant#26100)
  Fix google_maps scan interval (home-assistant#26328)
  Upgrade youtube_dl to 2019.09.01 (home-assistant#26330)
  Fix onvif camera setup error (home-assistant#24585)
  UniFi - use entity registry disabled_by to control available entities  (home-assistant#26141)
  Fetch Onkyo current radio preset (home-assistant#26211)
  Add precision argument to the Range Filter (home-assistant#25874)
  Fix alexa bad temp sensors (home-assistant#26307)
  deCONZ - Dont update entry if data is equal
  Add Withings support (home-assistant#25154)
  Add support for Homekit accessory battery sensors (home-assistant#26210)
  ...
@pgilad
Fix pylint warning
a10b2e5
@pgilad
Fix pylint import warning
005bb3a
@pgilad
Merge branch 'dev' into improve-bluetooth-tracker
8bedd8a 
* dev: (87 commits)
  Add atome sensor platform (home-assistant#26197)
  Replaces IOError by OSError (home-assistant#26428)
  Entity registry doesn't overwrite with None (home-assistant#24275)
  Add device to mqtt camera (home-assistant#26238)
  Updated frontend to 20190904.0 (home-assistant#26421)
  Add prettier to vscode (home-assistant#26417)
  NSW Rural Fire Service icon for geolocation entities (home-assistant#26416)
  Update azure-pipelines-translation.yml for Azure Pipelines
  [ci skip] Translation update
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Bumped version to 0.98.3
  Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413)
  Fix state report (home-assistant#26406)
  Update to 0.1.13 (home-assistant#26402)
  Met, check for existing location (home-assistant#26400)
  Allow core config updated (home-assistant#26398)
  Fix race during initial Sonos group construction (home-assistant#26371)
  ...
@pgilad
Merge with dev
8863244
@pgilad
Copy link
Copy Markdown
Contributor Author

pgilad commented Sep 4, 2019

Sorry had to manually resolve the conflict with dev branch, but it was a simple fix 😸

@pgilad
Copy link
Copy Markdown
Contributor Author

pgilad commented Sep 8, 2019

🏓 Hey - what's the next step to merge this code?

@pgilad
Copy link
Copy Markdown
Contributor Author

pgilad commented Sep 12, 2019

Hey @MartinHjelmare anything blocking this from getting merged? Something I can do?

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Sep 12, 2019

We're good.

@MartinHjelmare MartinHjelmare merged commit 25ef4a1 into home-assistant:dev Sep 12, 2019
@pgilad pgilad deleted the improve-bluetooth-tracker branch September 12, 2019 16:04
@lock lock Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pvizeli pvizeli pvizeli left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed integration: bluetooth_tracker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgilad @homeassistant @Mariusthvdb @MartinHjelmare @pvizeli