Add Plex config options support#26870
Merged
Merged
Conversation
Kane610
reviewed
Sep 24, 2019
2 tasks
Kane610
reviewed
Sep 24, 2019
| """Set up Plex from a config entry.""" | ||
| server_config = entry.data[PLEX_SERVER_CONFIG] | ||
|
|
||
| if MP_DOMAIN not in entry.options: |
Member
There was a problem hiding this comment.
Shouldn't you add tests for this as well?
Contributor
Author
There was a problem hiding this comment.
I'd eventually like to add tests for files outside of config_flow.py, but I'm not there quite yet.
jjlawren
force-pushed
the
plex_config_options
branch
from
5345563 to
ac58cb3
Compare
jjlawren
force-pushed
the
plex_config_options
branch
from
0b411ac to
a2cffd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add config options support for Plex
media_playerplatform options (use_episode_artandshow_all_controls).Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10450
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: