Skip to content

Add Hive Services#10474

Merged
frenck merged 2 commits into
home-assistant:nextfrom
KJonline:add_hive_services
Oct 1, 2019
Merged

Add Hive Services#10474
frenck merged 2 commits into
home-assistant:nextfrom
KJonline:add_hive_services

Conversation

@KJonline
Copy link
Copy Markdown
Contributor

@KJonline KJonline commented Sep 28, 2019

Description:
Following the merging of home-assistant/core#26789 this is the documentation to support it with the below PR fixing wording.

Pull request in home-assistant (if applicable): home-assistant/core#27038

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Sep 28, 2019
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Sep 28, 2019
@KJonline
Copy link
Copy Markdown
Contributor Author

Hi @frenck, I had issues trying to rebase the previous PR to get rid of the old commits out of it. the short story is I have created a different PR closing the other incorporating the changes you mentioned.

Comment thread source/_components/hive.markdown
Comment thread source/_components/hive.markdown
@klaasnicolaas klaasnicolaas added the ready-for-review This PR needs to be reviewed label Sep 28, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 29, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @KJonline! 👍

@frenck frenck dismissed klaasnicolaas’s stale review October 1, 2019 10:12

Comments addressed

@frenck frenck merged commit 464e2dd into home-assistant:next Oct 1, 2019
@probot-home-assistant probot-home-assistant Bot removed ready-for-review This PR needs to be reviewed parent-merged The parent PR has been merged already labels Oct 1, 2019
@KJonline KJonline deleted the add_hive_services branch October 4, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants