ZHA siren and warning device support#26046
Merged
Adminiuga merged 9 commits intoSep 20, 2019
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
Adminiuga
reviewed
Aug 23, 2019
dmulcahey
force-pushed
the
dm/zha-warning-device-support
branch
from
2288cee to
155b9c0
Compare
martin3000
reviewed
Sep 6, 2019
dmulcahey
force-pushed
the
dm/zha-warning-device-support
branch
from
8749145 to
cef6add
Compare
dmulcahey
force-pushed
the
dm/zha-warning-device-support
branch
from
b7af53b to
253d307
Compare
dmulcahey
changed the title
Contributor
|
Is it better to log the error and throw an exception? At least when calling the service from UI you gonna see notification about failed service call. |
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the IAS warning device channel and exposes services to interact with its commands that can be leveraged in automations.
Related issue (if applicable): fixes #25315
Checklist:
tox. Your PR cannot be merged unless tests pass