Skip to content

Add call direction sensor for Obihai#26867

Merged
MartinHjelmare merged 4 commits into
home-assistant:devfrom
dshokouhi:add_call_direction_sensor_obihai
Sep 25, 2019
Merged

Add call direction sensor for Obihai#26867
MartinHjelmare merged 4 commits into
home-assistant:devfrom
dshokouhi:add_call_direction_sensor_obihai

Conversation

@dshokouhi
Copy link
Copy Markdown
Member

Breaking Change:

Description:

Add a call direction sensor for Obihai. States are No Active Calls Inbound Call or Outbound Call

Related issue (if applicable): fixes #N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: obihai
    host: 192.168.1.x

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Comment thread homeassistant/components/obihai/sensor.py
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py
@MartinHjelmare
Copy link
Copy Markdown
Member

Not sure why pylint is failing.

@dshokouhi
Copy link
Copy Markdown
Member Author

@MartinHjelmare yea its failing for other PR's as well for the same or similar reason.

@dshokouhi dshokouhi force-pushed the add_call_direction_sensor_obihai branch from cb22894 to 6c80f18 Compare September 25, 2019 04:22
@dshokouhi
Copy link
Copy Markdown
Member Author

@MartinHjelmare I have force pushed my branch after rebasing it and the pylint error is now resolved :)

@MartinHjelmare MartinHjelmare merged commit 36f604f into home-assistant:dev Sep 25, 2019
@dshokouhi dshokouhi deleted the add_call_direction_sensor_obihai branch September 25, 2019 18:29
@lock lock Bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants