zha ZCL color loop effect#26549
Merged
Merged
Conversation
Contributor
Contributor
Author
|
I've tested this with Sylvania SMART+ (current US Osram Lightify?) A19 RGBW bulbs. |
Contributor
|
Can you format the code w/ black and update the PR so that it passes CI please? |
Contributor
|
@amigan here's some info on installing pre-commit hook https://developers.home-assistant.io/blog/2019/07/31/black.html |
Contributor
Author
|
Thank you. I've reformatted. |
Adminiuga
reviewed
Sep 12, 2019
Adminiuga
requested changes
Sep 12, 2019
Adminiuga
reviewed
Sep 12, 2019
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Otherwise looks good and can be merged once comments are addressed.
Adminiuga
approved these changes
Sep 14, 2019
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Good to merge when build passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for ZCL lighting color channel loop support.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: