Add config flow to transmission#26434
Conversation
|
Open Issue : 26334 |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Since the library doesn't support asyncio, we have to think about sync vs async context all the time in this integration. Please take care, especially when calling api functions.
I think we have a good separation now, considering this complication. All the methods on the TransmissionClient class are async. All the methods on the TransmissionData class are sync.
|
Please run |
There is an issue with this script and the black pre-commit (issue#26334). transmission is already in the list in this file |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Sorry, we require tests of the config flow too. It should be included in coverage calculation.
|
Please fix the CLA error. |
|
File config_flows.py is not up to date. Please run |
I am not able to commit after running the script. Black is adding a comma to the last line. |
|
Try rebasing on latest dev branch if that problem persists. We should have fixed it in the dev branch by turning off formattting of the generated files. |
|
Looks good! Please update |
|
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
Thanks for the opportunity to contribute in HA which I really like. I have added my username as code owner. |
|
Please add tests of the options flow too, to reach 100% test coverage of the config flow module. |
|
Please add a breaking change paragraph in the PR description and update the description with the current changes in the PR. The breaking change paragraph should describe briefly what changed and what the user needs to do to cope with the breaking change. |
Breaking Change:
The Transmission integration can now be configured through a config flow via
Integrationsin the GUI. Once configured all sensors and switches will be created and available for the user.monitored_conditionshas been removed so existing users need to update their configuration inconfiguration.yamland remove monitored conditions. The existing configuration will be imported as an entry under Integrations.Description:
In addition to the previous sensors and switches that were available under
monitored_conditionsa new switch tostartandstopall torrents has been added.The update Interval is now an option that can be altered under
options.Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10293
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.