Add iaqualink binary sensor and unique_id#26616
Merged
Merged
Conversation
Merged
2 tasks
Contributor
Author
|
Documentation at home-assistant/home-assistant.io#10354. |
Contributor
Author
|
@MartinHjelmare Is this a worthy 0.99 fix? |
MartinHjelmare
requested changes
Sep 13, 2019
Member
|
No, we won't add it to 0.99 since it's a new platform and new features. |
Member
|
Why does the entity_id change when we add the unique_id? |
Contributor
Author
I can't seem to reproduce but it was the case yesterday when I overrode unique_id. I've removed the integration, turned it back on (without unique_id), stopped HA, added unique_id, restarted HA and entity names didn't change this time. |
flz
force-pushed
the
iaqualink-binary-sensor
branch
from
d148711 to
bf20b4a
Compare
MartinHjelmare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new binary_sensor platform solving the issue with the freeze_protection sensor not being identified properly.
This also introduces the use of unique_id for all existing platforms to allow future multi-pool support.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10354
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: