Skip to content

deCONZ - create deconz_events through sensor platform#26592

Merged
Kane610 merged 5 commits into
home-assistant:devfrom
Kane610:deconz-events-created-from-sensors
Sep 13, 2019
Merged

deCONZ - create deconz_events through sensor platform#26592
Kane610 merged 5 commits into
home-assistant:devfrom
Kane610:deconz-events-created-from-sensors

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Sep 11, 2019

Breaking Change:

Description:

Gateway class shouldn't be responsible for creating deconz_events

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 changed the title deCONZ - events created from deconz_events through sensor platform deCONZ - create deconz_events through sensor platform Sep 11, 2019
@Kane610 Kane610 marked this pull request as ready for review September 13, 2019 22:15
@Kane610 Kane610 merged commit fb1acfc into home-assistant:dev Sep 13, 2019
@Kane610 Kane610 deleted the deconz-events-created-from-sensors branch September 13, 2019 22:16
@lock lock Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants