deCONZ device automations#26366
Conversation
|
Ping @balloob @emontnemery feedback wanted (half of the file is a copy paste from light device automation) Ive focused on getting something from async_get_triggers Current output is: |
There was a problem hiding this comment.
It took me 5 readings before I understood this. Can we put quotes around "turn on"?
Also, let's make the key not just turn_on, but instead be more precise, like remote_turn_on
There was a problem hiding this comment.
Actually wondering if we can come up with a better sentence.
|
@balloob no comments on the device automation? |
|
Can you update the example output in the description, it doesn't seem to match the implementation. |
|
Current output, 16 different triggers, it can probably be improved:
|
|
This is looking very solid. Couple of small comments and it's good to go. |
bc648e3 to
e3f1cf6
Compare
|
Whats left to do;
|
1e71f60 to
1e26581
Compare
|
Everything is ready, added tests and added subtype |
Add new exception InvalidDeviceAutomationConfig
1b65d83 to
d9f4b87
Compare

Breaking Change:
Description:
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: