HM-CC-TC was not recognized#26623
Merged
Merged
Conversation
Contributor
|
Hi @MajestyIV, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
probot-home-assistant
Bot
added
integration: homematic
small-pr
danielperna84
approved these changes
Sep 13, 2019
Contributor
danielperna84
left a comment
danielperna84
left a comment
There was a problem hiding this comment.
Seems ok for me. @pvizeli ?
Contributor
Author
|
@pvizeli Any words on this? Would be great if we could get a solution into the repository. |
pvizeli
requested changes
Sep 23, 2019
| if HMIP_CONTROL_MODE in self._data: | ||
| return self._data[HMIP_CONTROL_MODE] | ||
| # Homematic | ||
| return self._data["CONTROL_MODE"] |
| mode = mode.lower() | ||
| except KeyError: | ||
| # In case that the device has no control mode | ||
| return None |
Member
There was a problem hiding this comment.
Instead, to fire an exception, we should add a guard before.
if not self._hm_control_mode:
return None
Contributor
Author
|
What about the _hm_control_mode function? |
Member
|
There is a comment about |
Contributor
Author
|
Sorry, missed that part. I made the changed, tested it and it work. Thanks! |
pvizeli
approved these changes
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25196 Description: Fixes Homematic HM-TC-CC exception. This device has no control mode what leads to an ecxeption.
Related issue (if applicable): fixes #25455
Checklist:
tox. Your PR cannot be merged unless tests pass