Skip to content

Make uk_transport sensor timezone/DST aware#26577

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
tsvi:patch-2
Sep 11, 2019
Merged

Make uk_transport sensor timezone/DST aware#26577
MartinHjelmare merged 2 commits into
home-assistant:devfrom
tsvi:patch-2

Conversation

@tsvi
Copy link
Copy Markdown
Contributor

@tsvi tsvi commented Sep 11, 2019

Breaking Change:

Description:

When getting now, we should use dt_util.now so it is timezone aware

Related issue (if applicable): fixes #26237

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare
Copy link
Copy Markdown
Member

Please rebase on latest dev branch to let the build pass.

@tsvi
Copy link
Copy Markdown
Contributor Author

tsvi commented Sep 11, 2019

@MartinHjelmare ready for merge

@MartinHjelmare MartinHjelmare merged commit f53fcac into home-assistant:dev Sep 11, 2019
@tsvi tsvi deleted the patch-2 branch September 11, 2019 14:39
@tsvi tsvi restored the patch-2 branch September 11, 2019 15:00
@tsvi tsvi deleted the patch-2 branch September 11, 2019 15:06
@tsvi tsvi restored the patch-2 branch September 11, 2019 15:07
@tsvi tsvi deleted the patch-2 branch September 11, 2019 15:28
@lock lock Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uk_transport monitor doesn't respect DST.

3 participants