Skip to content

Add Obihai integration#26537

Merged
MartinHjelmare merged 8 commits into
home-assistant:devfrom
dshokouhi:add_obihai
Sep 11, 2019
Merged

Add Obihai integration#26537
MartinHjelmare merged 8 commits into
home-assistant:devfrom
dshokouhi:add_obihai

Conversation

@dshokouhi
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi commented Sep 9, 2019

Breaking Change:

Description:

Integration for Obihai devices to pull the line status.

Related issue (if applicable): fixes #n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10324

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: obihai
    host: 192.168.1.10
    username: admin
    password: 12345

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py Outdated
Comment thread homeassistant/components/obihai/sensor.py
Comment thread homeassistant/components/obihai/sensor.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment.

Comment thread homeassistant/components/obihai/sensor.py Outdated
@dshokouhi
Copy link
Copy Markdown
Member Author

closing to reopen as CI errors are not related

@dshokouhi dshokouhi closed this Sep 10, 2019
@dshokouhi dshokouhi reopened this Sep 10, 2019
@dshokouhi
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 2b30f47 into home-assistant:dev Sep 11, 2019
@dshokouhi dshokouhi deleted the add_obihai branch September 11, 2019 17:31
@lock lock Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants