feat(upscaling): sharpening slider

[doodlum]

Summary by CodeRabbit

• New Features

  • Added NVIDIA Image Scaling (NIS) sharpening with adjustable strength; applied post-upscale when supported.
  • Separate sharpness controls for FSR and DLSS.
  • Automatic fallback to an alternate upscaling method when DLSS isn’t available.
  • Default upscaling method set to DLSS on supported systems.

• Chores

  • Bumped Upscaling feature version to 1.1.0.
  • Removed bundled XeSS license file.

[coderabbitai]

Warning

Rate limit exceeded

@doodlum has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 10 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8799a7f and 49aa777.

📒 Files selected for processing (1)

• src/Features/Upscaling.cpp (9 hunks)

Walkthrough

Adds NIS sharpening integration and DLSS-aware method selection to Upscaling. Introduces sharpness controls, new textures, and public APIs. Updates FidelityFX Upscale to accept a sharpness parameter. Extends Streamline to load/apply NIS. Bumps Upscaling feature version and removes a XeSS license file.

Changes

Cohort / File(s)	Summary of Changes
Version metadata features/Upscaling/Shaders/Features/Upscaling.ini	Incremented [Info] version from 1-0-0 to 1-1-0.
Removed license features/Upscaling/Shaders/Upscaling/XeSS/LICENSE.txt	Deleted Intel XeSS license file.
Upscaling settings, UI, resources, execution src/Features/Upscaling.h, src/Features/Upscaling.cpp	Added Settings.upscaleMethodNoDLSS, sharpnessFSR, sharpnessDLSS; default upscaleMethod → kDLSS. Added nisSharpenerTexture and ApplyNISSharpening(). Selection logic now uses non-DLSS method when DLSS unavailable. FSR upscale now takes sharpness; DLSS path invokes NIS sharpening. Resource create/destroy updated (incl. NIS sharpener texture). UI shows method-conditional sharpness controls.
FidelityFX API src/Features/Upscaling/FidelityFX.h, src/Features/Upscaling/FidelityFX.cpp	Upscale signature extended with float a_sharpness; internal dispatch uses provided sharpness.
Streamline NIS integration src/Features/Upscaling/Streamline.h, src/Features/Upscaling/Streamline.cpp	Added NIS feature flag, function pointers, and ApplyNISSharpening(ID3D11Resource*, float). Load/check NIS in feature setup; set options and evaluate per frame; added logging.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as UI
  participant Ups as Upscaling
  participant FFX as FidelityFX
  participant SL as Streamline (DLSS/NIS)

  UI->>Ups: DrawSettings / Apply
  alt DLSS available
    Ups->>Ups: GetUpscaleMethod() => kDLSS
    Ups->>SL: Evaluate DLSS (unchanged)
    note over Ups,SL: Post-processing complete
    Ups->>SL: ApplyNISSharpening(texture, sharpnessDLSS)
    SL-->>Ups: Done / status
  else DLSS unavailable
    Ups->>Ups: GetUpscaleMethod() => upscaleMethodNoDLSS
    alt Method == FSR
      Ups->>FFX: Upscale(..., motionVectors, sharpnessFSR)
      FFX-->>Ups: Upscaled frame
    else Method == TAA/Other
      Ups-->>UI: Render with selected method
    end
  end

Loading

sequenceDiagram
  autonumber
  participant Init as Init/Device
  participant SL as Streamline
  participant Ups as Upscaling

  Init->>SL: PostDevice()
  SL->>SL: Load features: DLSS, NIS
  SL-->>Ups: featureDLSS/featureNIS status
  note over SL: Hook slNISSetOptions/slNISGetState when available

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• feat(upscaling): add nis sharpening #1457 — Adds NIS sharpening support and related Upscaling/Streamline wiring, overlapping with new ApplyNISSharpening and textures.
• chore(upscaling): simplify interop and upscale methods #1514 — Changes FidelityFX::Upscale API/signature, aligning with this PR’s added sharpness parameter.
• fix: misc fixes #1474 — Adjusts NIS pathway and resource handling in Upscaling.cpp, similar to this PR’s NIS texture/setup changes.

Suggested reviewers

• alandtse
• doodlum
• jiayev

Poem

I tuned the pixels, nibble by nibble,
FSR’s spice and DLSS’s dribble.
A nib of NIS, so crisp and bright—
I thump my paws at sharpened light.
Version hops, licenses whisk,
Carrots cached—frames render brisk! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.70% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly identifies the primary enhancement—adding a sharpening slider to the upscaling feature—matching the UI and code changes for adjustable sharpness parameters across upscaling methods.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 48266de
Using base ref: 48266de
Base commit date: 2025-09-25T16:02:06+01:00 (Thursday, September 25, 2025 04:02 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Features/Upscaling.cpp (1)

14-22: Ensure sharpness settings round-trip via JSON

Line 17 updates Settings with new sharpness fields, but the serialization macro still omits them. As a result, any sharpness changes are discarded on save/load, so users will see the sliders reset every launch. Please wire the new members into the macro so they persist.

 NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT(
 	Upscaling::Settings,
 	upscaleMethod,
 	upscaleMethodNoDLSS,
 	qualityMode,
 	frameLimitMode,
 	frameGenerationMode,
 	frameGenerationForceEnable,
-	streamlineLogLevel);
+	streamlineLogLevel,
+	sharpnessFSR,
+	sharpnessDLSS);

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48266de and 8799a7f.

⛔ Files ignored due to path filters (2)

• features/Upscaling/Shaders/Upscaling/Streamline/sl.nis.dll is excluded by !**/*.dll
• features/Upscaling/Shaders/Upscaling/XeSS/libxess.dll is excluded by !**/*.dll

📒 Files selected for processing (8)

• features/Upscaling/Shaders/Features/Upscaling.ini (1 hunks)
• features/Upscaling/Shaders/Upscaling/XeSS/LICENSE.txt (0 hunks)
• src/Features/Upscaling.cpp (9 hunks)
• src/Features/Upscaling.h (3 hunks)
• src/Features/Upscaling/FidelityFX.cpp (2 hunks)
• src/Features/Upscaling/FidelityFX.h (1 hunks)
• src/Features/Upscaling/Streamline.cpp (4 hunks)
• src/Features/Upscaling/Streamline.h (4 hunks)

💤 Files with no reviewable changes (1)

• features/Upscaling/Shaders/Upscaling/XeSS/LICENSE.txt

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Features/Upscaling/FidelityFX.h
• src/Features/Upscaling/Streamline.h
• src/Features/Upscaling/FidelityFX.cpp
• src/Features/Upscaling.h
• src/Features/Upscaling/Streamline.cpp
• src/Features/Upscaling.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Features/Upscaling/FidelityFX.h
• src/Features/Upscaling/Streamline.h
• src/Features/Upscaling/FidelityFX.cpp
• src/Features/Upscaling.h
• src/Features/Upscaling/Streamline.cpp
• src/Features/Upscaling.cpp

🔇 Additional comments (5)

features/Upscaling/Shaders/Features/Upscaling.ini (1)

1-2: Version bump looks consistent.

The feature version aligns with the new sharpening work—no issues spotted.

src/Features/Upscaling/FidelityFX.h (1)

49-49: Signature update aligns with sharpness plumbing.

The additional sharpness parameter matches the implementation path and keeps the public API coherent.

src/Features/Upscaling/FidelityFX.cpp (1)

304-306: Sharpness propagation looks correct.

Passing the caller-provided sharpness straight into the dispatch keeps the FSR path in sync with the new slider.

src/Features/Upscaling.h (1)

51-60: Settings additions cover DLSS fallback & sharpness.

The dual defaults (with and without DLSS) and per-method sharpness knobs make sense for the new UI flow.

src/Features/Upscaling/Streamline.h (1)

65-90: NIS hooks are wired cleanly.

The new function pointers and helper keep the Streamline façade tidy for sharpening support.

[github-actions]

✅ A pre-release build is available for this PR:
Download