chore: remove unused hooks

[doodlum]

Summary by CodeRabbit

• Bug Fixes
  • Improves consistency of interior sun and lighting rendering in interiors, reducing visual anomalies.
• Refactor
  • Streamlined render pass handling during initialization for more predictable behavior.
• Chores
  • Removed obsolete hooks related to snow rendering and multiple immediate render-pass variants to simplify startup and reduce overhead.

[coderabbitai]

Walkthrough

Adds a new InteriorSun thunk for BSBatchRenderer_RenderPassImmediately that updates raster state before delegating. Declares the thunk and relocation in InteriorSun.h and wires it during initialization. Removes prior RenderPassImmediately hook variants and the CreateRenderTarget_Snow hook from Hooks.cpp, along with their registrations and logs.

Changes

Cohort / File(s)	Summary
InteriorSun thunk addition src/Features/InteriorSun.cpp, src/Features/InteriorSun.h	Introduces InteriorSun::BSBatchRenderer_RenderPassImmediately::thunk(...) and its relocation; updates initialization to route calls through the thunk to adjust cull mode before invoking the original render pass.
Hooks cleanup src/Hooks.cpp	Deletes CreateRenderTarget_Snow hook and three BSBatchRenderer_RenderPassImmediately* thunk variants; removes their registrations and related logs.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Game
  participant BSBatchRenderer
  participant InteriorSunThunk as InteriorSun::RenderPassImmediately::thunk
  participant InteriorSun as InteriorSun::UpdateRasterStateCullMode
  participant Orig as Original RenderPassImmediately

  Game->>BSBatchRenderer: Issue render pass (interior)
  BSBatchRenderer->>InteriorSunThunk: Call RenderPassImmediately(...)
  InteriorSunThunk->>InteriorSun: UpdateRasterStateCullMode()
  InteriorSunThunk->>Orig: Delegate to original RenderPassImmediately(...)
  Orig-->>Game: Render completed
  note over InteriorSunThunk,Orig: Thunk inserted during PostPostLoad init

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: fix effect shader decals #1186 — Also modifies BSBatchRenderer_RenderPassImmediately handling to update raster state before delegation.

Suggested reviewers

• davo0411
• jiayev

Poem

A sunbeam hops through shader glades,
I tweak the cull, adjust the shades—
Old hooks unhooked, the path made clean,
New thunk burrows right between.
With whisker math and raster cheer,
Interior skies grow bright and clear. 🌞🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "chore: remove unused hooks" is concise and accurately reflects the primary work in the changeset, which removes the Snow render target hook and several BSBatchRenderer_RenderPassImmediately hook variants and their registrations; it is not vague and clearly conveys the main intent. The diff does include an added InteriorSun thunk and its hookup, but titles do not need to list every small addition and this does not make the provided title misleading. Overall the title summarizes the main developer intent and is appropriate for the PR.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-hooks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: a04ff60
Using base ref: a04ff60
Base commit date: 2025-09-22T13:31:21+01:00 (Monday, September 22, 2025 01:31 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a04ff60 and fae9eeb.

📒 Files selected for processing (3)

• src/Features/InteriorSun.cpp (2 hunks)
• src/Features/InteriorSun.h (1 hunks)
• src/Hooks.cpp (0 hunks)

💤 Files with no reviewable changes (1)

• src/Hooks.cpp

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Features/InteriorSun.cpp
• src/Features/InteriorSun.h

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Features/InteriorSun.cpp
• src/Features/InteriorSun.h

🧠 Learnings (1)

📓 Common learnings

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (2)

src/Features/InteriorSun.cpp (1)

128-133: Thunk ordering is correct; minimal hot‑path overhead.

Calling UpdateRasterStateCullMode before delegating keeps state changes localized to shadowmap passes. Looks good.

Please sanity‑check that a_pass->shaderProperty is always valid at this callsite on all runtimes. If not guaranteed, add a fast null check in UpdateRasterStateCullMode to prevent rare CTDs in malformed passes.

src/Features/InteriorSun.h (1)

53-57: New thunk declaration looks correct — confirm signature stability across SE/AE/VR. Repo search returned no matches for RenderPassImmediately or BSBatchRenderer, so the original prototype could not be verified; ensure the thunk's parameter list exactly matches the engine signature on SE, AE, and VR to avoid runtime mis-calls.

[github-actions]

✅ A pre-release build is available for this PR:
Download