ci: run shader validation on CMake and CI config changes

[Copilot]

Shader validation currently only triggers on HLSL file changes. Build system changes (CMakeLists.txt, cmake/**, etc.) and CI configuration changes can break shader compilation but skip validation.

Changes

• Added granular cmake and ci file change categories to track shader-compilation-related files
• Updated check-changes job output to include CMake and CI changes in hlsl-should-build condition
• Added cmake/**, .github/workflows/**, and .github/configs/** to the pull_request_target trigger paths filter to ensure the workflow runs for these file changes

# Before
hlsl-should-build: ${{ steps.changed-files.outputs.hlsl_any_changed == 'true' || steps.changed-files.conclusion == 'failure' }}

# After  
hlsl-should-build: ${{ steps.changed-files.outputs.hlsl_any_changed == 'true' || steps.changed-files.outputs.cmake_any_changed == 'true' || steps.changed-files.outputs.ci_any_changed == 'true' || steps.changed-files.conclusion == 'failure' }}

Shader validation now runs when any of these change:

• CMake files: CMakeLists.txt, CMakePresets.json, cmake/**
• CI files: .github/workflows/, .github/configs/

Dependency-only changes (vcpkg.json, .gitmodules, extern/**) do not trigger shader validation to avoid unnecessary runs.

• Fixes Shader validation should also run with cmake or other build changes #1605

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Shader validation should also run with cmake or other build changes</issue_title>
<issue_description>Currently shader validation only runs when hlsl files are changed. As shown with a recent fix, changes in the Cmake list build process can also break the ci checks. We should ensure that changes to Cmakelist.txt and related build files runs the full ci suite. </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Shader validation should also run with cmake or other build changes #1605

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'instructions'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alandtse]

Should dependency changes be included? I can see ci and build related files potentially breaking the ci but dependencies shouldn't right? Is it because the change job action doesn't allow the necessary granularity on the files/ci yaml files?

@copilot

[Copilot]

Should dependency changes be included? I can see ci and build related files potentially breaking the ci but dependencies shouldn't right? Is it because the change job action doesn't allow the necessar...

You're right - dependencies shouldn't trigger shader validation. I've refined the approach to be more granular.

Created separate cmake and ci categories that only include files directly related to shader compilation:

• cmake: CMakeLists.txt, CMakePresets.json, cmake/**
• ci: .github/workflows/, .github/configs/

Excluded from shader validation triggers:

• vcpkg.json, vcpkg-configuration.json (C++ dependencies)
• .gitmodules, extern/** (external dependencies)

Commit: ab249c2

[Copilot]

Pull Request Overview

This PR extends shader validation triggers to run not only on HLSL file changes, but also when CMake build configuration or CI configuration files are modified. This prevents build system changes from breaking shader compilation without detection.

Key changes:

• Added cmake and ci file change detection categories to the check-changes job
• Updated hlsl-should-build output condition to include CMake and CI changes alongside HLSL changes

[alandtse]

@coderabbitai please create a new issue to address the syntax errors you reported in #1606 (comment) for .coderabbit.yaml. Leave it as unassigned with a help-wanted tag.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch the specific comment to see what syntax errors were reported
gh api /repos/doodlum/skyrim-community-shaders/issues/comments/3539384946 --jq '.body'

Length of output: 2025

---

🏁 Script executed:

#!/bin/bash
# Create a new issue for the .coderabbit.yaml syntax error
gh issue create \
  --repo doodlum/skyrim-community-shaders \
  --title "Fix syntax errors in .coderabbit.yaml configuration" \
  --body "## Description

The \`.coderabbit.yaml\` configuration file contains unrecognized properties that are being ignored by CodeRabbit.

## Validation Error

\`\`\`
Validation error: Unrecognized key(s) in object: 'instructions'
\`\`\`

## Details

The \`instructions\` property is not recognized in the CodeRabbit configuration schema and should be removed or corrected according to the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit).

## References

- Pull Request: https://github.com/doodlum/skyrim-community-shaders/pull/1606
- Original Comment: https://github.com/doodlum/skyrim-community-shaders/pull/1606#issuecomment-3539384946
- Requested by: @alandtse

## Resources

- [CodeRabbit Configuration Documentation](https://docs.coderabbit.ai/guides/configure-coderabbit)
- [Online YAML Validator](https://docs.coderabbit.ai/configuration/yaml-validator)
- Configuration Schema: https://coderabbit.ai/integrations/schema.v2.json" \
  --label "help wanted"

Length of output: 63

---

@alandtse: I've created issue #1607 to address the .coderabbit.yaml syntax error. The issue documents the validation error about the unrecognized instructions property, includes references to this PR and the original comment, and has been tagged with the "help wanted" label. It's currently unassigned as requested.

---

🧠 Learnings used

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

---

Learnt from: ThePagi
Repo: doodlum/skyrim-community-shaders PR: 1369
File: src/Features/SnowCover.cpp:515-515
Timestamp: 2025-10-02T14:20:33.454Z
Learning: In the Community Shaders codebase (skyrim-community-shaders repository), hardcoded shader resource slot numbers are used directly in code rather than being defined as named constants. This is the established convention and should not be flagged as an issue.

---

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: On Linux/WSL, do not attempt to build or validate shaders; limit work to code review, docs, and Python tooling