Skip to content

fix(upscaling): reduce default value for RCAS#1694

Merged
davo0411 merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:sharpening-defaults
Jan 12, 2026
Merged

fix(upscaling): reduce default value for RCAS#1694
davo0411 merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:sharpening-defaults

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Jan 11, 2026

Reduced the default sharpness of RCAS, values around 0.5 are more balanced and still allow the user to increase or decrease it when necessary. 1.0 was very oversharpened.

Summary by CodeRabbit

  • Chores
    • Adjusted default upscaling sharpness setting to provide optimized visual quality baseline.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 11, 2026

📝 Walkthrough

Walkthrough

A single default value adjustment in the Upscaling settings, reducing the DLSS sharpness initializer from 1.0f to 0.5f within the Settings structure. This is a straightforward configuration value modification affecting only the header declaration.

Changes

Cohort / File(s) Summary
Upscaling Settings
src/Features/Upscaling.h
Default value of Settings.sharpnessDLSS reduced from 1.0f to 0.5f

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • davo0411
  • doodlum

Poem

🐰 A tweak of sharpness, oh so fine,
From one to half—a gentle line,
DLSS now smoother, not so keen,
The finest tuning ever seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reducing the default RCAS sharpness value from 1.0f to 0.5f, which aligns with the changeset and PR objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dfddc4 and 4629d54.

📒 Files selected for processing (1)
  • src/Features/Upscaling.h
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

  • src/Features/Upscaling.h
src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

  • src/Features/Upscaling.h
**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

  1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
    if the existing title does not describe the code changes):
    Format: type(scope): description
    Length: 50 characters limit for title, 72 for body
    Style: lowercase description, no ending period
    Examples:

    • feat(vr): add cross-eye sampling
    • fix(water): resolve flowmap bug
    • docs: update shader documentation
  2. Issue References (if PR fixes bugs or implements features):
    Suggest adding appropriate GitHub keywords:

Otherwise, use your standard review approach focusing on code quality.

Files:

  • src/Features/Upscaling.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build plugin and addons
🔇 Additional comments (1)
src/Features/Upscaling.h (1)

59-59: LGTM! Sensible default reduction for RCAS sharpening.

Reducing the default from 1.0 to 0.5 is a reasonable balance—full-strength RCAS can introduce noticeable haloing and edge artifacts, especially on already-sharp content. The 0.5 value provides visible sharpening while leaving headroom for users who prefer more aggressive settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Using provided base ref: 4dfddc4
Using base ref: 4dfddc4
Base commit date: 2026-01-11T18:23:29Z (Sunday, January 11, 2026 06:23 PM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@davo0411 davo0411 merged commit 94f854f into community-shaders:dev Jan 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants