build: fix shader copying to relative paths

[alandtse]

Summary by CodeRabbit

• Chores
  • Enhanced shader validation in the build workflow for Windows environments.
  • Streamlined shader file organization in the build output structure.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'instructions'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The changes modify the CI workflow to discover fxc.exe on Windows runners and pass its path to shader validation steps. Additionally, the shader file copy destination in CMakeLists.txt is flattened from a per-feature subdirectory structure to a single flat directory layout.

Changes

Cohort / File(s)	Summary
CI Workflow Enhancements .github/workflows/build.yaml	Adds PowerShell step to locate fxc.exe on Windows, checking PATH and common SDK locations; outputs result to fxc_path. Shader validation step now requires valid fxc path and passes it via --fxc flag to hlslkit-compile. Adds Python and hlslkit setup steps. Validation fails early if fxc.exe is not found.
Build Output Path Restructuring CMakeLists.txt	Changes shader file copy destination from nested per-feature structure (${AIO_DIR}/Shaders/${_feat_name}/${_rel}) to flat layout (${AIO_DIR}/Shaders/${_rel}), removing the feature-name subdirectory level.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Workflow logic: Verify PowerShell fxc.exe discovery logic correctly handles missing SDK paths and properly exports fxc_path output for downstream steps.
• Path flattening: Confirm shader relative paths remain valid after removing feature-name nesting and that all downstream tools expect the new flat structure.

Possibly related PRs

• ci: always run cpp-build #1149: Introduces PowerShell step modifications to build.yaml workflow.
• build: add cmake install commands #1372: Modifies shader preparation and copy workflow in CMake with related packaging targets.
• ci: add hlsl validation #1145: Adds shader-validation CI job and CMake prepare_shaders target that this PR now integrates.

Suggested reviewers

• doodlum

Poem

🐰 A rabbit hops through paths so true,
Finding fxc where shaders flew,
Flattened folders, nested no more,
Validation flows to the build's front door! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically describes the main change: fixing shader copying to use relative paths instead of feature-name subdirectories.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 268de33 and e04be4c.

📒 Files selected for processing (2)

• .github/workflows/build.yaml (2 hunks)
• CMakeLists.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Learnt from: ThePagi
Repo: doodlum/skyrim-community-shaders PR: 1369
File: src/Features/SnowCover.cpp:515-515
Timestamp: 2025-10-02T14:20:33.454Z
Learning: In the Community Shaders codebase (skyrim-community-shaders repository), hardcoded shader resource slot numbers are used directly in code rather than being defined as named constants. This is the established convention and should not be flagged as an issue.

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: On Linux/WSL, do not attempt to build or validate shaders; limit work to code review, docs, and Python tooling

Learnt from: jiayev
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-08-03T18:37:19.690Z
Learning: ISReflectionsRayTracing.hlsl and ISWorldMap.hlsl in the skyrim-community-shaders repository are image-space post-processing shaders that perform color sampling and blending operations that need proper linear color space handling for the linear lighting system. ISReflectionsRayTracing handles screen-space reflections and should use conditional Color::IrradianceToLinear/Gamma conversions similar to ISCompositeLensFlareVolumetricLighting.hlsl. ISWorldMap performs 7x7 color accumulation that should be done in linear space similar to the pattern used in ISSAOComposite.hlsl.

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Avoid GPU register/buffer conflicts in HLSL; verify register usage (e.g., with hlslkit buffer scanning)

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Place all feature shaders under features/YourFeature/Shaders/

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Place all feature shaders under features/YourFeature/Shaders/

Applied to files:

• CMakeLists.txt

📚 Learning: 2025-07-05T05:20:45.823Z

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Applied to files:

• CMakeLists.txt

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: On Linux/WSL, do not attempt to build or validate shaders; limit work to code review, docs, and Python tooling

Applied to files:

• .github/workflows/build.yaml

📚 Learning: 2025-08-17T18:37:35.839Z

Learnt from: CR
Repo: doodlum/skyrim-community-shaders PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-17T18:37:35.839Z
Learning: Applies to features/*/Shaders/**/*.{hlsl,hlsli,fx,fxh} : Avoid GPU register/buffer conflicts in HLSL; verify register usage (e.g., with hlslkit buffer scanning)

Applied to files:

• .github/workflows/build.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Upload results
• GitHub Check: Build plugin and addons

🔇 Additional comments (3)

CMakeLists.txt (1)

476-478: ✓ Correct shader path flattening.

The change removes redundant feature-name nesting in the destination path, fixing the double-nesting issue where feature shaders would be copied to AIO_DIR/Shaders/${feat_name}/${feat_name}/*. By preserving the relative path ${_rel}, the directory structure within features is maintained correctly. The added comments clearly explain the rationale.

.github/workflows/build.yaml (2)

390-420: ✓ Robust fxc.exe discovery and validation error handling.

The fxc.exe discovery logic is well-structured: it tries Get-Command first, then falls back to searching Windows SDK installation directories (x64-only, which is appropriate for the windows-2022 runner). The validation step properly checks for an empty path and fails early with a clear, actionable error message.

Also applies to: 469-477

---

450-456: Disregard this review comment—the referenced files do not exist in this repository.

The review comment references .github/workflows/build.yaml (lines 450-456), CMakeLists.txt, and CMakePresets.json, none of which exist in the doodlum/skyrim-community-shaders repository. The codebase contains no .github directory, no CMake configuration files, and no YAML workflows. The review appears to be based on incorrect assumptions about the repository structure and cannot be validated against actual code that doesn't exist.

Likely an incorrect or invalid review comment.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 actionlint (1.7.8)

.github/workflows/build.yaml

could not read ".github/workflows/build.yaml": open .github/workflows/build.yaml: no such file or directory

🔧 YAMLlint (1.37.1)

.github/workflows/build.yaml

[Errno 2] No such file or directory: '.github/workflows/build.yaml'

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 268de33
Using base ref: 268de33
Base commit date: 2025-11-06T14:39:17+10:00 (Thursday, November 06, 2025 02:39 PM)
No actionable suggestions for changed features.

[Copilot]

Pull Request Overview

This PR fixes shader file copying in the CMake build system to preserve the correct directory structure for shader includes. The change removes an intermediate feature name subdirectory that was breaking relative include paths.

• Changed shader destination from AIO_DIR/Shaders/{feature_name}/{rel_path} to AIO_DIR/Shaders/{rel_path} to match package layout
• Added fxc.exe location logic in the GitHub Actions workflow to explicitly find and pass the shader compiler path
• Modified shader validation step to check for fxc.exe availability and pass it to hlslkit-compile

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
CMakeLists.txt	Removes feature name subdirectory from shader copy destination path to preserve include paths like "TerrainShadows/..."
.github/workflows/build.yaml	Adds fxc.exe discovery step and passes explicit fxc path to hlslkit-compile with error checking

[github-actions]

✅ A pre-release build is available for this PR:
Download