build: add compile-time validation of GPU buffers

[Copilot]

• Implement C++ static assert validation for GPU buffer alignment
• Add STATIC_ASSERT_ALIGNAS_16 macro to Buffer.h
• Apply validation to all cbuffer structures across codebase
• Sync with latest dev branch to resolve CI build failures

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[alandtse]

The original intent was to add the checks to the cpp files that populated the cbuffers. See the closed PR referenced in the issue. The issue may not have made that clear.

Does it make sense to handle on the hlsl or cpp side? It seems like we're building an elaborate system from scratch to solve it from the hlsl side. Is this the best approach? If we do handle it from the hlsl side, can we leverage existing tools?

[alandtse]

@copilot The original intent was to add the checks to the cpp files that populated the cbuffers. See the closed PR referenced in the issue. The issue may not have made that clear.

Does it make sense to handle on the hlsl or cpp side? It seems like we're building an elaborate system from scratch to solve it from the hlsl side. Is this the best approach? If we do handle it from the hlsl side, can we leverage existing tools?

[Copilot]

@copilot The original intent was to add the checks to the cpp files that populated the cbuffers. See the closed PR referenced in the issue. The issue may not have made that clear.

Does it make sense...

You're absolutely right. The C++ approach is much simpler and more appropriate. I'll revert to the C++ static_assert approach from PR #542, which validates buffer alignment at compile time where the structs are defined. This leverages existing C++ tooling and avoids building custom infrastructure from scratch.

The original intent was to add the checks to the cpp files that populated the cbuffers. See the closed PR referenced in the issue. The issue may not have made that clear.

Does it make sense to handl...

I've implemented the C++ static_assert approach from your original PR #542. The solution now uses a simple STATIC_ASSERT_ALIGNAS_16 macro in Buffer.h and applies it to all cbuffer structures across the codebase. This leverages existing C++ tooling and is much simpler than the HLSL-based system I initially created. Commit: 73a6fc1

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/doodlum/skyrim-community-shaders/pulls/542
  • Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[github-actions]

Using provided base ref: 967b8ad
Using base ref: 967b8ad
Base commit date: 2025-11-16T20:12:56Z (Sunday, November 16, 2025 08:12 PM)
No actionable suggestions for changed features.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'instructions'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[alandtse]

@copilot please sync with latest dev branch, that should resolve the unrelated ci build failures.

[Copilot]

@copilot please sync with latest dev branch, that should resolve the unrelated ci build failures.

Synced with latest dev branch in commit 826e947. The merge was successful without conflicts and all buffer validation changes have been preserved.

[github-actions]

✅ A pre-release build is available for this PR:
Download