feat(llf): move llf to core

[doodlum]

Summary by CodeRabbit

• Chores
  • Updated LightLimitFix to be treated as a core feature within the application’s feature system. This change does not alter any user-facing behavior, settings, or workflows.
  • Improves consistency and reliability in how the feature is recognized across configurations and environments.
  • No action required from users; existing functionality remains the same.

[coderabbitai]

Walkthrough

Adds an override of IsCore() returning true to LightLimitFix in src/Features/LightLimitFix.h, marking it as a core feature. No other methods or logic paths are modified.

Changes

Cohort / File(s)	Summary
Core-flag override src/Features/LightLimitFix.h	Added virtual bool IsCore() const override { return true; } to LightLimitFix. No other changes; SupportsVR() unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Engine
    participant FeatureManager
    participant LightLimitFix

    Engine->>FeatureManager: Initialize features
    FeatureManager->>LightLimitFix: IsCore()
    Note right of LightLimitFix: Override returns true
    LightLimitFix-->>FeatureManager: true
    FeatureManager-->>Engine: Register as core feature

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• refactor(ibl): move ibl to core feature #1396 — Adds the same IsCore() override returning true to a different feature (IBL), paralleling this change.

Suggested reviewers

• alandtse

Poem

I nudge the lights, a core at heart,
A tiny flag, a crucial part.
Hop-hop, I mark the path as true,
So managers know just what to do.
Carrots aligned, features in queue—
Core buns confirmed. ✨🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "feat(llf): move llf to core" succinctly and accurately summarizes the PR's primary intent: moving LLF to core. The changeset shows a single, focused modification—adding an IsCore() override that returns true on LightLimitFix—which directly implements that intent. The title is concise, specific to the affected component, and clear enough for a teammate scanning history.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch llf-core

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd48e10 and 8775617.

📒 Files selected for processing (1)

• src/Features/LightLimitFix.h (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Features/LightLimitFix.h

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Features/LightLimitFix.h

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/Features/LightLimitFix.h (1)

301-301: Cannot verify — src/Features/LightLimitFix.h not found; confirm LLF core promotion effects (UI, settings, load order).

Repo search returned no C++ matches for IsCore or LightLimitFix (only shader files at features/Light Limit Fix/Shaders/LightLimitFix/). Provide the correct header path or run and paste results for these checks: rg -n -C3 '\bIsCore\s*(' ; rg -n -C3 '\bLightLimitFix\b' ; rg -n -C3 'LightLimitFix.{0,200}(Enable|Enabled|save|load|serialize)'.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: dd48e10
Using base ref: dd48e10
Base commit date: 2025-09-19T03:51:21+01:00 (Friday, September 19, 2025 03:51 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download