fix(build): fix Package-AIO-Manual for fresh pulls

[midona-rhel]

The Package-AIO-Manual custom command used WORKING_DIRECTORY ${AIO_DIR}, but MSBuild validates that the
working directory exists before running any commands. On fresh builds where build/ALL/aio doesn't
exist, the entire command fails immediately.

To repro remove build/ALL/aio then run cmake --build build/ALL --target Package-AIO-Manual

Summary by CodeRabbit

• Chores
  • Improved build system reliability by ensuring proper directory creation during package assembly operations.
  • Optimized package creation workflow for enhanced consistency and stability across build environments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request modifies the CMake build configuration to ensure the AIO package directory exists before creating the package archive. It replaces the working directory approach with a cmake -E chdir wrapper for executing the tar operation from within the target directory.

Changes

Cohort / File(s)	Summary
AIO Package Build Process CMakeLists.txt	Added directory creation command to ensure AIO_DIR exists before packaging. Replaced WORKING_DIRECTORY with cmake -E chdir wrapper to execute tar from within the AIO_DIR, improving cross-platform compatibility for the AIO package generation step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Verify directory creation command works across target platforms (Windows, Linux, macOS)
• Confirm cmake -E chdir approach is compatible with the CMake version requirements
• Validate that the tar operation path logic remains correct with the new invocation method

Possibly related PRs

• build: fix zipping aio #1579: Related modification to AIO packaging logic, changing the packaging step to use a dedicated AIO_ZIP_PACKAGE target.

Suggested reviewers

• alandtse
• doodlum

Poem

🐰 A directory blooms before the tar's great dance,
cmake -E chdir grants a second chance,
No more WORKING_DIRECTORY's weary way,
The AIO package finds its path today! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main issue: fixing the Package-AIO-Manual build target to work on fresh pulls where the AIO directory doesn't exist yet.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 520945a and 0edb38e.

📒 Files selected for processing (1)

• CMakeLists.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
   if the existing title does not describe the code changes):
   Format: type(scope): description
   Length: 50 characters limit for title, 72 for body
   Style: lowercase description, no ending period
   Examples:

   • feat(vr): add cross-eye sampling
   • fix(water): resolve flowmap bug
   • docs: update shader documentation

2. Issue References (if PR fixes bugs or implements features):
   Suggest adding appropriate GitHub keywords:

   • "Fixes feat: increased portal strict light limit #123" or "Closes feat: increased portal strict light limit #123" for bug fixes
   • "Implements feat: increased portal strict light limit #123" or "Addresses feat: increased portal strict light limit #123" for features
   • "Related to feat: increased portal strict light limit #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

• CMakeLists.txt

🧠 Learnings (1)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)
• GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)
• GitHub Check: Build plugin and addons

🔇 Additional comments (2)

CMakeLists.txt (2)

849-856: Fix correctly addresses the MSBuild working directory validation issue.

The addition of make_directory (line 849) ensures the AIO_DIR exists before the install and tar commands execute, and the cmake -E chdir wrapper (lines 851-853) avoids relying on MSBuild's working directory validation—the root cause of failures on fresh builds. This approach is consistent with other manual packaging targets in the file and follows established CMake patterns from the PREPARE_AIO target (lines 336–344).

---

1-1: Consider adding an issue reference to the PR description.

The PR title follows the conventional commit format well (fix(build): fix Package-AIO-Manual for fresh pulls). If this fix addresses a tracked issue, consider adding a reference like "Fixes #XXXX" or "Closes #XXXX" to the PR description to link the change to any corresponding issue. As per coding guidelines, this helps with traceability.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 520945a
Using base ref: 520945a
Base commit date: 2025-12-03T01:43:28-08:00 (Wednesday, December 03, 2025 01:43 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download