fix(perf-overlay): removed ImGuiTableFlags_ScrollX/Y for scroll bar issues

[kuplion]

Removed ImGuiTableFlags_ScrollX/Y from UI.h to correct the behaviour of ImGuiWindowFlags_NoInputs and stop scroll bars hiding elements of the performance overlay.

Summary by CodeRabbit

• Bug Fixes
  • Modified table display behavior to adjust default scrolling functionality. Tables will no longer enforce explicit horizontal and vertical scrolling flags, allowing sizing to be determined by container layout instead.

[coderabbitai]

Walkthrough

The PR removes horizontal and vertical scrolling flags (ImGuiTableFlags_ScrollX and ImGuiTableFlags_ScrollY) from table factory calls in two functions within src/Utils/UI.h: ShowSortedStringTableCustom and ShowInteractiveTable. Tables retain Borders, RowBg, Sortable, Resizable, and SizingStretchProp flags.

Changes

Cohort / File(s)	Summary
Table scrolling flag removal src/Utils/UI.h	Removed ImGuiTableFlags_ScrollX and ImGuiTableFlags_ScrollY from internal table factory calls in ShowSortedStringTableCustom and ShowInteractiveTable functions, simplifying the flags to Borders, RowBg, Sortable, Resizable, and SizingStretchProp

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single file modification with consistent, repetitive pattern change applied identically to two functions
• No new logic or structural changes, purely flag removal
• Low complexity reasoning required per site

Possibly related PRs

• refactor(perf-overlay): remove collapsible headers #1572 — Modifies the same table-rendering helpers (ShowSortedStringTableCustom / ShowInteractiveTable) in the UI utilities
• fix(perf-overlay): fix infinite draw calls table height #1590 — Addresses scrolling and sizing behavior of ImGui tables in ShowSortedStringTableCustom with related changes

Suggested reviewers

• davo0411
• alandtse

Poem

🐰 Scroll flags hop away,
Tables bare and light today,
Cleaner code in every way,
ImGui borders here to stay! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing ImGuiTableFlags_ScrollX/Y flags from the performance overlay UI code to fix scroll bar issues.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 3f14125
Using base ref: 3f14125
Base commit date: 2025-11-05T22:33:36Z (Wednesday, November 05, 2025 10:33 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f14125 and 1aac87f.

📒 Files selected for processing (1)

• src/Utils/UI.h (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Utils/UI.h

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Utils/UI.h

🧠 Learnings (1)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 577
File: src/Features/WetnessEffects.h:36-36
Timestamp: 2025-06-08T11:25:14.536Z
Learning: In the skyrim-community-shaders project, boolean flags in C++ structs that interface with HLSL shaders use `uint` type instead of `bool` for compatibility reasons. This ensures consistent size, alignment, and cross-platform compatibility when passing data to shader constant buffers.

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 577
File: src/Features/WetnessEffects.h:36-36
Timestamp: 2025-06-08T11:25:14.536Z
Learning: In the skyrim-community-shaders project, boolean flags in C++ structs that interface with HLSL shaders use `uint` type instead of `bool` for compatibility reasons. This ensures consistent 4-byte size, proper 16-byte alignment in constant buffers, and cross-platform compatibility when passing data between C++ and HLSL shaders.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/Utils/UI.h (1)

977-977: LGTM - Consistent with container-based scrolling pattern.

This change correctly removes redundant scroll flags since the table is already wrapped in a scrollable BeginChild container (line 974) with ImGuiWindowFlags_HorizontalScrollbar. The container handles scrolling, making table-level scroll flags unnecessary and potentially problematic.

This approach is more maintainable as it:

• Eliminates the input handling conflict with ImGuiWindowFlags_NoInputs
• Uses explicit container-based scrolling (line 974) rather than implicit table scrolling
• Maintains consistent behavior with ShowSortedStringTableCustom at line 392

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Change correctly addresses ImGuiWindowFlags_NoInputs conflict.

Removing the scroll flags fixes the input handling issue with ImGuiWindowFlags_NoInputs windows (like the performance overlay). When scroll flags are set on tables inside NoInputs windows, the scrollbars can interfere with the NoInputs behavior and hide elements.

However, note that this delegates scrolling responsibility to the caller. Callers of ShowSortedStringTableCustom must now ensure that:

• Tables are wrapped in scrollable parent containers (e.g., BeginChild with scroll flags), OR
• The parent window provides scrolling, OR
• Row counts are limited to fit within the visible area

Please verify that existing call sites of ShowSortedStringTableCustom handle scrolling appropriately. Run the following script to identify call sites:

---

🏁 Script executed:

#!/bin/bash
# Find all call sites of ShowSortedStringTableCustom to verify scrolling is handled

rg -n -C5 'ShowSortedStringTableCustom\s*<' --type=cpp

Length of output: 2466

---

---

🏁 Script executed:

```shell
#!/bin/bash
# Get context around the two PerformanceOverlay.cpp call sites
echo "=== Context around line 625 (PerformanceOverlay.cpp) ==="
sed -n '600,650p' src/Features/PerformanceOverlay.cpp

echo ""
echo "=== Context around line 1331 (PerformanceOverlay.cpp) ==="
sed -n '1300,1350p' src/Features/PerformanceOverlay.cpp

Length of output: 3651

---

---

🏁 Script executed:

```shell
#!/bin/bash
# Check if DrawABTestResultsTable or its caller is wrapped in scrolling contexts
echo "=== Search for DrawABTestResultsTable caller context ==="
rg -n -B10 'DrawABTestResultsTable\(' src/Features/PerformanceOverlay.cpp | head -30

echo ""
echo "=== Check performance overlay rendering function context ==="
# Find what calls the function around line 1331 - look for the function signature
sed -n '1280,1335p' src/Features/PerformanceOverlay.cpp | head -20

Length of output: 1770

---

---

🏁 Script executed:

```shell
#!/bin/bash
# Find where DrawDrawCallsTable is called
echo "=== Search for DrawDrawCallsTable caller ==="
rg -n 'DrawDrawCallsTable\(' src/Features/PerformanceOverlay.cpp

echo ""
echo "=== Check main overlay rendering function context (around line 1184) ==="
sed -n '1140,1200p' src/Features/PerformanceOverlay.cpp

Length of output: 2655

---

---

🏁 Script executed:

```shell
#!/bin/bash
# Find context around line 383 and the caller of DrawABTestSection
echo "=== Context around line 383 (DrawDrawCallsTable call) ==="
sed -n '360,400p' src/Features/PerformanceOverlay.cpp

echo ""
echo "=== Search for DrawABTestSection caller ==="
rg -n 'DrawABTestSection\(' src/Features/PerformanceOverlay.cpp

Length of output: 1286

---

---

🏁 Script executed:

```shell
#!/bin/bash
# Find the function containing lines 360-398
grep -n "^void.*PerformanceOverlay::" src/Features/PerformanceOverlay.cpp | awk -F: '{print $1}' | while read line; do
  if [ $line -lt 360 ]; then
    last_func_line=$line
  fi
done

# Get more aggressive - find function signature by looking backwards from line 360
sed -n '1,360p' src/Features/PerformanceOverlay.cpp | tail -100 | head -50

echo ""
echo "=== Check if main window uses BeginChild or scroll flags ==="
sed -n '320,365p' src/Features/PerformanceOverlay.cpp

Length of output: 3578

---

Critical scrolling regression in performance overlay tables—fix required.

The change correctly handles scrolling in src/Utils/UI.h:564, where the table is wrapped in a scrollable BeginChild container. However, the two performance overlay call sites are now broken:

1. Line 625 (DrawABTestResultsTable): Table rendered directly in main overlay window without scroll capability
2. Line 1331 (DrawDrawCallsTable): Table rendered directly in main overlay window without scroll capability

Both tables now have no internal scrolling and no parent scrolling container. While the main overlay window uses ImGuiWindowFlags_AlwaysAutoResize, this causes the window to expand infinitely to accommodate all rows—making the overlay impractically large instead of scrollable.

Required fixes:

• Wrap both ShowSortedStringTableCustom calls in BeginChild with ImGuiWindowFlags_HorizontalScrollbar (matching the pattern at UI.h:560), OR
• Identify an alternative approach to handle the ImGuiWindowFlags_NoInputs conflict that preserves internal table scrolling

[davo0411]

@kuplion address please

[coderabbitai]

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

[kuplion]

Copied from discussion on Discord re the PR and testing, for clarity:

Draw Calls Table seems to behave the same with or without the changes, bar the ability to interact with it when not intended (menu closed/game being played)

AB Test Results Table does seem to behave the same as well, with scrolling available with and without the changes when the menu is open, but I'm not familiar enough with this particular part of the performance overlay to say with complete certainty that it's working as intended, though it does seem so.

It might be noteworthy that the AI is suggesting that horizontal scrolling is the issue but I didn't experience any horizontal scrolling or need for it on either table, with dev or the pr build. Even with a very narrow performance overlay neither table added a horizontal scroll bar, only verticals ones if the overlay contained more information than could be displayed without scrolling.

I couldn't work out where exactly to implement the suggested changes so haven't tested that (sorry, just a novice coder here for the most part)

[github-actions]

✅ A pre-release build is available for this PR:
Download