build: fix warnings

[alandtse]

Summary by CodeRabbit

• Improvements
  • Refined HDR bloom calculation for smoother highlight rendering and reduced haloing.
  • Adjusted shadow/contrast response to preserve more detail in dark areas and improve tonal balance.
  • Improved highlight roll-off for more consistent visuals across varying scene brightness.
  • Overall HDR visuals appear more natural and balanced without user action.

[coderabbitai]

Walkthrough

Shader math adjustments in ISHDR.hlsl: bloom modulation now calls RangeCompress with two parameters, and contrast/shadow computation applies exponent after normalizing hdrColor by avgValue.x. The RangeCompress function signature is updated accordingly within the shader.

Changes

Cohort / File(s)	Summary
HDR mapping and bloom adjustments package/Shaders/ISHDR.hlsl	- Switched bloom term to DisplayMapping::RangeCompress(max(0.0f, Param.xxx - hdrColor), 0.0f) - Reworked contrast/shadows: pow(abs(hdrColor / avgValue.x), Cinematic.z) * avgValue.x * sign(hdrColor) - Updated signature: RangeCompress(float, float)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: fix bloom intensity #1458 — Earlier change to the same bloom RangeCompress call; this PR updates to the new two-arg form.
• chore: improve contrast function #1470 — Touches the same contrast/shadows expression adjusted here.
• feat: improved hdr post processing #1445 — Also modifies ISHDR.hlsl affecting bloom and tone mapping, including RangeCompress usage.

Suggested reviewers

• jiayev

Poem

I twiddle light with whiskered grace,
Compress the bloom, a gentler face;
Shadows dance where tones align,
Normalize, then let them shine.
Hop by hop, the pixels gleam—
A bunny’s tweak to shape the scene. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "build: fix warnings" accurately communicates the PR's intent to address build/shader warnings and is related to the actual changes, which update DisplayMapping::RangeCompress's signature and adjust expressions in package/Shaders/ISHDR.hlsl to remove/avoid warnings; it is concise and focused on the primary purpose rather than listing files or implementation details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: bfafeff
Using base ref: bfafeff
Base commit date: 2025-09-22T00:39:30+01:00 (Monday, September 22, 2025 12:39 AM)
No actionable suggestions for changed features.

[Copilot]

Pull Request Overview

Fix compiler warnings in the ISHDR shader by making type usage explicit and tightening vector operations.

• Replace implicit int-to-float and scalar-to-vector promotions with explicit float literals and swizzles
• Reorder absolute value and division to avoid negative bases in pow and potential warnings
• Update RangeCompress invocation to align with expected parameter types

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

package/Shaders/ISHDR.hlsl (1)

109-117: Guard divisions by avgValue.x; reduce divides with rcp

Avoid INF/NaNs on dark frames and cut duplicate divides.

Apply:

 float2 avgValue = AvgTex.Sample(AvgSampler, input.TexCoord.xy).xy;
 
-hdrColor *= avgValue.y / avgValue.x;
+// Clamp denominator and use reciprocal for performance/stability
+float invAvgX = rcp(max(1e-3f, avgValue.x));
+hdrColor *= avgValue.y * invAvgX;
 
-hdrColor += DisplayMapping::RangeCompress(max(0.0f, Param.xxx - hdrColor), 0.0f) * bloomColor;
+hdrColor += DisplayMapping::RangeCompress(max(0.0f, Param.xxx - hdrColor), 0.0f) * bloomColor;
 
 float3 contrastOriginal = lerp(avgValue.x, hdrColor, Cinematic.z);
-float3 contrastShadows = pow(abs(hdrColor / avgValue.x), Cinematic.z) * avgValue.x * sign(hdrColor);
+float3 contrastShadows = pow(max(abs(hdrColor * invAvgX), 1e-6f), Cinematic.z) * avgValue.x * sign(hdrColor);

Optional: if Cinematic.z can be ≤ 0 at runtime, the max(..., 1e-6f) prevents pow(0, non‑positive) issues.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfafeff and 5d1cdec.

📒 Files selected for processing (1)

• package/Shaders/ISHDR.hlsl (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• package/Shaders/ISHDR.hlsl

🧠 Learnings (2)

📓 Common learnings

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Learnt from: jiayev
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-08-03T18:37:19.690Z
Learning: ISReflectionsRayTracing.hlsl and ISWorldMap.hlsl in the skyrim-community-shaders repository are image-space post-processing shaders that perform color sampling and blending operations that need proper linear color space handling for the linear lighting system. ISReflectionsRayTracing handles screen-space reflections and should use conditional Color::IrradianceToLinear/Gamma conversions similar to ISCompositeLensFlareVolumetricLighting.hlsl. ISWorldMap performs 7x7 color accumulation that should be done in linear space similar to the pattern used in ISSAOComposite.hlsl.

📚 Learning: 2025-08-03T18:37:19.690Z

Learnt from: jiayev
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-08-03T18:37:19.690Z
Learning: ISReflectionsRayTracing.hlsl and ISWorldMap.hlsl in the skyrim-community-shaders repository are image-space post-processing shaders that perform color sampling and blending operations that need proper linear color space handling for the linear lighting system. ISReflectionsRayTracing handles screen-space reflections and should use conditional Color::IrradianceToLinear/Gamma conversions similar to ISCompositeLensFlareVolumetricLighting.hlsl. ISWorldMap performs 7x7 color accumulation that should be done in linear space similar to the pattern used in ISSAOComposite.hlsl.

Applied to files:

• package/Shaders/ISHDR.hlsl

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build plugin and addons
• GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)
• GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)

🔇 Additional comments (1)

package/Shaders/ISHDR.hlsl (1)

113-113: Confirm RangeCompress float3 overload and call-sites

Confirm DisplayMapping::RangeCompress provides a float3 (or templated) overload; Common/DisplayMapping.hlsli was not found in the repo (included at package/Shaders/ISHDR.hlsl:66). Repo search found only the 2‑arg call at package/Shaders/ISHDR.hlsl:113 and no remaining single‑arg usages.

[github-actions]

✅ A pre-release build is available for this PR:
Download