fix(ui): enter key now behaves properly when first time popup is open

[soda3000]

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where pressing Enter or Escape during first-time setup could unintentionally be registered as hotkey assignments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Modified the hotkey handling loop in src/Menu.cpp to add a guard that prevents Enter and Escape keys from being captured as hotkeys during first-time setup. When these keys are pressed in this context, the hotkey-capture flag is cancelled and the loop exits.

Changes

Cohort / File(s)	Summary
Hotkey handling guard src/Menu.cpp	Added conditional check in the hotkey handling loop to prevent Enter/Escape key capture during first-time setup; cancels hotkey-capture flag and exits loop when condition is met

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Single file with localized change to hotkey handling logic
• Straightforward conditional guard added to existing loop
• No architectural or multi-file coordination concerns

Poem

🐰 A guard stands at the hotkey gate,
Enter and Escape won't seal their fate,
In setup's dance, they skip the line—
First-time flow now works just fine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: preventing the Enter key from being incorrectly captured as a hotkey during first-time setup, which is the core change in Menu.cpp.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b102274 and 34ca4e5.

📒 Files selected for processing (1)

• src/Menu.cpp (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Menu.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Menu.cpp

**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
   if the existing title does not describe the code changes):
   Format: type(scope): description
   Length: 50 characters limit for title, 72 for body
   Style: lowercase description, no ending period
   Examples:

   • feat(vr): add cross-eye sampling
   • fix(water): resolve flowmap bug
   • docs: update shader documentation

2. Issue References (if PR fixes bugs or implements features):
   Suggest adding appropriate GitHub keywords:

   • "Fixes feat: increased portal strict light limit #123" or "Closes feat: increased portal strict light limit #123" for bug fixes
   • "Implements feat: increased portal strict light limit #123" or "Addresses feat: increased portal strict light limit #123" for features
   • "Related to feat: increased portal strict light limit #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

• src/Menu.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (2)

src/Menu.cpp (2)

686-692: LGTM! Good fix for first-time setup UX.

The guard correctly prevents Enter and Escape from being captured as hotkeys during first-time setup, reserving them for dialog navigation. The key events still reach ImGui (line 726) so the dialog can respond properly, and after setup completes, these keys can be bound normally if desired.

---

686-692: PR title follows conventional commits format correctly.

The title "fix(ui): enter key now behaves properly when first time popup is open" properly follows the conventional commits specification with appropriate type, scope, and description.

As per coding guidelines, this meets the requirements for commit message formatting.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: b102274
Using base ref: b102274
Base commit date: 2025-11-19T11:19:34Z (Wednesday, November 19, 2025 11:19 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[midona-rhel]

Looks good, tried and seems to fix it