fix: use proper filename settingsuser.json

[davo0411]

when i made the menu startup window system i got the usersettings.json wrong, it is supposed to be settingsuser.json. this is now rectified.

Summary by CodeRabbit

• Bug Fixes

  • Standardized the settings file path used by the app to resolve inconsistencies that could prevent user settings from loading in some cases.

• Documentation

  • Updated in-app and developer-facing references to reflect the corrected settings path for consistency.

• Chores

  • Aligned internal references to the settings location to ensure uniform behavior across features.

[coderabbitai]

Walkthrough

Renames references from UserSettings.json to SettingsUser.json. Updates the literal return path in GetUserSettingsPath(), aligns comments and documentation in HomePageRenderer and FileSystem.h. No logic, signatures, control flow, or error handling changed.

Changes

Cohort / File(s)	Summary of Changes
Path return update src/Utils/FileSystem.cpp	Changed GetUserSettingsPath() to return "CommunityShaders/SettingsUser.json" instead of "CommunityShaders/UserSettings.json".
Comments and docs alignment src/Menu/HomePageRenderer.cpp, src/Utils/FileSystem.h	Updated references and documentation strings to use "SettingsUser.json" for consistency; no code logic modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(ui): add welcome window #1431 — Renames UserSettings.json to SettingsUser.json in the same path helper and HomePageRenderer areas.

Suggested reviewers

• alandtse

Poem

I twitch my whiskers, hop with glee,
A name made right in directory!
From User to Settings—neat and done,
The paths align, the files are one.
Thump-thump cheers from bunny crew,
Consistent trails to burrow through. 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title is concise and directly describes the primary change—correcting the configuration filename to settingsuser.json—so it accurately reflects the PR objectives and the diffs and is a clear single-line summary for reviewers.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: aa301ab
Using base ref: aa301ab
Base commit date: 2025-09-18T06:56:46+01:00 (Thursday, September 18, 2025 06:56 AM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Utils/FileSystem.h (1)

47-51: Docs update looks correct; consider deprecating the duplicate getter to avoid ambiguity.

Both GetUserSettingsPath() and GetSettingsUserPath() now point to SettingsUser.json. To steer call sites toward a single canonical API, mark GetUserSettingsPath() as deprecated (non‑breaking) so we don’t carry two names long‑term.

Apply this minimal annotation:

-        std::filesystem::path GetUserSettingsPath();
+        [[deprecated("Use GetSettingsUserPath()")]]
+        std::filesystem::path GetUserSettingsPath();

src/Menu/HomePageRenderer.cpp (1)

456-466: Comment rename to SettingsUser.json is accurate.

No logic changes; this aligns with the new canonical filename. Once the deprecation above is in place, consider switching calls here to GetSettingsUserPath() to quiet future warnings.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa301ab and b20e667.

📒 Files selected for processing (3)

• src/Menu/HomePageRenderer.cpp (1 hunks)
• src/Utils/FileSystem.cpp (1 hunks)
• src/Utils/FileSystem.h (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Utils/FileSystem.h
• src/Utils/FileSystem.cpp
• src/Menu/HomePageRenderer.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Utils/FileSystem.h
• src/Utils/FileSystem.cpp
• src/Menu/HomePageRenderer.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build plugin and addons
• GitHub Check: Feature Version Audit (PR)

🔇 Additional comments (1)

src/Utils/FileSystem.cpp (1)

41-44: Prevent settings regression: migrate legacy UserSettings.json to SettingsUser.json.

Renaming risks triggering first‑time setup and losing user preferences — migrate legacy UserSettings.json to SettingsUser.json inside GetUserSettingsPath.

File: src/Utils/FileSystem.cpp Lines: 41-44

 std::filesystem::path GetUserSettingsPath()
 {
-    return GetCommunityShaderPath() / "SettingsUser.json";
+    const auto newPath = GetCommunityShaderPath() / "SettingsUser.json";
+    const auto legacyPath = GetCommunityShaderPath() / "UserSettings.json";
+    try {
+        if (!std::filesystem::exists(newPath) && std::filesystem::exists(legacyPath)) {
+            std::filesystem::create_directories(newPath.parent_path());
+            try {
+                std::filesystem::rename(legacyPath, newPath);  // fast, same directory
+            } catch (const std::filesystem::filesystem_error&) {
+                // fallback when rename fails (locked/cross-device)
+                std::filesystem::copy_file(
+                    legacyPath, newPath,
+                    std::filesystem::copy_options::overwrite_existing);
+                std::filesystem::remove(legacyPath);
+            }
+            logger::info("Migrated legacy UserSettings.json to SettingsUser.json");
+        }
+    } catch (const std::exception& e) {
+        logger::warn("Failed to migrate legacy UserSettings.json: {}", e.what());
+    }
+    return newPath;
 }

Run the three verification rg checks from the original comment locally/CI to confirm there are no lingering "UserSettings.json" references.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[alandtse]

This implies we have hardcoded paths that should just use the helper function so we only have to update one place.