build: fix zipping aio

[jiayev]

This pull request updates the packaging logic in the CMakeLists.txt file to improve how the AIO (All-In-One) ZIP package is generated. The main change is replacing the post-build command with a dedicated custom target, which enhances build control and dependency management.

Build system improvements:

• Replaced the add_custom_command (post-build) with an add_custom_target named AIO_ZIP_PACKAGE, making the ZIP packaging a distinct build target. This allows for better integration with build workflows and easier invocation of packaging independently.
• Added DEPENDS PREPARE_AIO to ensure the packaging step only runs after the preparation step completes, improving build reliability and correctness.

Summary by CodeRabbit

• Chores
  • Restructured the build process to ensure package creation runs reliably as an independent operation.

[coderabbitai]

Walkthrough

The build system has been refactored to convert a post-build custom command attached to the project target into a standalone custom target named AIO_ZIP_PACKAGE with the ALL flag that depends on PREPARE_AIO, enabling independent and guaranteed execution during builds.

Changes

Cohort / File(s)	Summary
Build Target Refactoring CMakeLists.txt	Replaced POST_BUILD custom command on project target with new custom target AIO_ZIP_PACKAGE configured with ALL flag and DEPENDS PREPARE_AIO. The zip operation content remains unchanged; only the invocation mechanism shifts from embedded post-build to standalone target.

Sequence Diagram

sequenceDiagram
    participant Build as Build System
    participant Old as Old Flow
    participant New as New Flow
    participant Prep as PREPARE_AIO
    participant Zip as ZIP Operation

    rect rgb(240, 248, 255)
    Note over Old: Before: POST_BUILD Command
    Build->>Old: Build PROJECT_NAME target
    Old->>Zip: Execute zip (post-build hook)
    end

    rect rgb(240, 248, 255)
    Note over New: After: Standalone Target
    Build->>New: Build AIO_ZIP_PACKAGE target
    New->>Prep: Verify PREPARE_AIO completed
    Prep-->>New: Ready
    New->>Zip: Execute zip (independent target)
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

The change is a straightforward build configuration refactoring affecting a single file. Review requires verification that the new target structure correctly preserves the original zip operation, confirms the PREPARE_AIO dependency is appropriate, and ensures the ALL flag achieves the intended build behavior.

Poem

🐰 A zip target hops free,
No longer bound post-build it will be,
With ALL and DEPENDS so neat,
The build chain's complete—oh what a treat! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The pull request title "build: fix zipping aio" is specific and directly related to the changeset. It accurately references the AIO ZIP packaging functionality that is being modified, communicating that a build-related fix has been applied to the zipping process. While the title doesn't capture the full architectural detail that the fix involves refactoring from a post-build command to a dedicated custom target with improved dependency ordering, it does refer to the observable change and would allow a developer scanning the commit history to understand this addresses the AIO zipping functionality. The title follows conventional commit format and is appropriately concise.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 79aebb6
Using base ref: 79aebb6
Base commit date: 2025-10-18T22:52:09+01:00 (Saturday, October 18, 2025 10:52 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

CMakeLists.txt (1)

665-673: Consider using OUTPUT + stamp file to avoid always-rebuilding the zip.

Currently, since AIO_ZIP_PACKAGE has no OUTPUT clause, it will be considered out-of-date and always rebuild the zip on every invocation. While this preserves the prior POST_BUILD behavior (which also always rebuilt), adopting the PREPARE_AIO pattern with an intermediate stamp file would improve build efficiency. The zip would then only rebuild when PREPARE_AIO changes.

Consider refactoring to match the PREPARE_AIO pattern:

+    add_custom_command(
+        OUTPUT aio_zip.stamp
         COMMAND
             ${CMAKE_COMMAND} -E tar cf
             ${CMAKE_SOURCE_DIR}/dist/${TARGET_AIO_ZIP} --format=7zip -- .
+        COMMAND ${CMAKE_COMMAND} -E touch aio_zip.stamp
         WORKING_DIRECTORY ${AIO_DIR}
+        DEPENDS PREPARE_AIO
+        COMMENT "Creating AIO zip package"
+    )
+
     add_custom_target(
         AIO_ZIP_PACKAGE
         ALL
-        COMMAND
-            ${CMAKE_COMMAND} -E tar cf
-            ${CMAKE_SOURCE_DIR}/dist/${TARGET_AIO_ZIP} --format=7zip -- .
-        WORKING_DIRECTORY ${AIO_DIR}
-        DEPENDS PREPARE_AIO
+        DEPENDS aio_zip.stamp
     )

This change makes the zip rebuild only when its dependencies (PREPARE_AIO) actually change, rather than on every build.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79aebb6 and d9c54e8.

📒 Files selected for processing (1)

• CMakeLists.txt (1 hunks)

🔇 Additional comments (1)

CMakeLists.txt (1)

665-673: Refactoring to standalone target improves build dependency ordering.

The conversion from a POST_BUILD custom command to an explicit add_custom_target with DEPENDS PREPARE_AIO is correct and improves clarity. The dependency chain is sound: PREPARE_AIO (which depends on ${PROJECT_NAME} and package files) → AIO_ZIP_PACKAGE ensures proper sequencing. Variable scoping and flag usage (ALL) are correct.

[github-actions]

✅ A pre-release build is available for this PR:
Download