fix(ui): add constraints for discord banner size

[davo0411]

Makes the discord banner scale with window size and have padding on edges to not get cut off.

Summary by CodeRabbit

• New Features
  • Home page Discord banner now scales responsively with window size while preserving aspect ratio.
  • Enforces sensible minimum and maximum widths plus padding to avoid overflow or overly small rendering.
  • Automatically centers the banner for a consistent layout across resolutions.
  • Preserves existing hover, tooltip, and fallback behavior for the Discord icon.

[coderabbitai]

Walkthrough

Reworks Discord banner sizing in HomePageRenderer to compute a scaled target width from window width and a ratio, preserve aspect ratio, clamp between min/max and padding-based bounds, then center and render the icon. Adds four public constexpr sizing constants and an include.

Changes

Cohort / File(s)	Summary of Changes
Renderer logic update src/Menu/HomePageRenderer.cpp	Added #include <algorithm>. Rewrote banner sizing in RenderWelcomeSection to compute ratioWidth = windowWidth * DISCORD_BANNER_TARGET_WIDTH_RATIO, derive aspectRatio from the original icon size, compute an upper bound using DISCORD_BANNER_MAX_WIDTH and DISCORD_BANNER_PADDING_MARGIN, clamp targetWidth between DISCORD_BANNER_MIN_WIDTH and that upper bound, set iconSize = (targetWidth, targetWidth * aspectRatio), and retain centering, hover/tooltip, and fallback behaviors.
Public constants addition src/Menu/HomePageRenderer.h	Added public static constexpr float constants: DISCORD_BANNER_TARGET_WIDTH_RATIO, DISCORD_BANNER_MIN_WIDTH, DISCORD_BANNER_MAX_WIDTH, DISCORD_BANNER_PADDING_MARGIN. No public API/signature changes.

Sequence Diagram(s)

sequenceDiagram
    participant UI as HomePageRenderer
    participant Win as Window
    participant Assets as Icon Cache
    participant ImGui as ImGui

    UI->>Win: query window width
    UI->>Assets: request Discord icon original size
    Note right of UI: ratioWidth = windowWidth * DISCORD_BANNER_TARGET_WIDTH_RATIO
    Note right of UI: aspectRatio = originalHeight / originalWidth
    Note right of UI: upperBound = min(DISCORD_BANNER_MAX_WIDTH, max(1, windowWidth - DISCORD_BANNER_PADDING_MARGIN))
    Note right of UI: targetWidth = clamp(ratioWidth, DISCORD_BANNER_MIN_WIDTH, upperBound)
    UI->>UI: iconSize = (targetWidth, targetWidth * aspectRatio)
    UI->>ImGui: draw centered banner with iconSize
    ImGui-->>UI: hover events / tooltip
    Note over Assets,UI: fallback path if icon unavailable (unchanged)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• alandtse

Poem

I nudged the width to fit the scene,
Kept aspect true and margins clean.
I clamp, I center, I scale with care,
A tidy banner skimming air.
— A rabbit who tweaks the UI 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "fix(ui): add constraints for discord banner size" is concise, single-line, and accurately summarizes the primary change in the PR (adding sizing constraints and resize logic for the Discord banner), matching the file-level changes that introduce min/max/padding constants and a scaled sizing path. It is specific enough for a teammate scanning history and avoids vague wording.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba36ad0 and e313049.

📒 Files selected for processing (2)

• src/Menu/HomePageRenderer.cpp (1 hunks)
• src/Menu/HomePageRenderer.h (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/Menu/HomePageRenderer.cpp
• src/Menu/HomePageRenderer.h

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 1cd2640
Using base ref: 1cd2640
Base commit date: 2025-09-21T20:25:25+01:00 (Sunday, September 21, 2025 08:25 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/Menu/HomePageRenderer.h (1)

15-20: Fix misleading comment (85% vs 25%).

Value is 0.85f (85%), but the comment says 25%.

Apply:

- static constexpr float DISCORD_BANNER_TARGET_WIDTH_RATIO = 0.85f;  // 25% of window width
+ static constexpr float DISCORD_BANNER_TARGET_WIDTH_RATIO = 0.85f;  // 85% of window width

Optional: consider deriving DISCORD_BANNER_PADDING_MARGIN from ImGui::GetStyle() to better match theme spacing.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01da25a and 582eb79.

📒 Files selected for processing (2)

• src/Menu/HomePageRenderer.cpp (2 hunks)
• src/Menu/HomePageRenderer.h (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Menu/HomePageRenderer.h
• src/Menu/HomePageRenderer.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Menu/HomePageRenderer.h
• src/Menu/HomePageRenderer.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/Menu/HomePageRenderer.cpp (1)

4-4: Include is appropriate.

Needed for std::min/std::max (and std::clamp if applied below).

[github-actions]

✅ A pre-release build is available for this PR:
Download