Skip to content

docs(estree/tokens): correct comment#19873

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-docs_estree_tokens_correct_comment
Mar 1, 2026
Merged

docs(estree/tokens): correct comment#19873
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-docs_estree_tokens_correct_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 1, 2026

Just correct 2 comments.

Copy link
Member Author

overlookmotel commented Mar 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a single-line documentation comment in the is_ts method implementation within JsonContext. The previous comment incorrectly stated "Returns true if serializing in JS style" (the inverse of the method's actual behavior), which is now fixed to "Returns true if serializing in TS style." This aligns the comment with the identical docstring used in all other is_ts definitions across the codebase.

Changes:

  • Corrects the docstring for JsonContext's is_ts implementation from "JS style" to "TS style"

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/03-01-docs_estree_tokens_correct_comment (1d7aff9) with om/03-01-refactor_estree_tokens_move_json-related_code_into_subdirectory (229a1e9)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel self-assigned this Mar 1, 2026
@overlookmotel overlookmotel added A-parser Area - Parser A-linter-plugins Area - Linter JS plugins labels Mar 1, 2026
@overlookmotel overlookmotel force-pushed the om/03-01-refactor_estree_tokens_move_json-related_code_into_subdirectory branch from 6d0e686 to 229a1e9 Compare March 1, 2026 16:40
@overlookmotel overlookmotel force-pushed the om/03-01-docs_estree_tokens_correct_comment branch from fd11f79 to 1d7aff9 Compare March 1, 2026 16:40
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_move_json-related_code_into_subdirectory branch from 229a1e9 to 6ef7e2f Compare March 1, 2026 16:59
@graphite-app graphite-app bot force-pushed the om/03-01-docs_estree_tokens_correct_comment branch from 1d7aff9 to 909bbe8 Compare March 1, 2026 16:59
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 1, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_move_json-related_code_into_subdirectory branch from 6ef7e2f to 4636d4f Compare March 1, 2026 17:14
@graphite-app graphite-app bot force-pushed the om/03-01-docs_estree_tokens_correct_comment branch from 909bbe8 to b2b7a64 Compare March 1, 2026 17:15
Base automatically changed from om/03-01-refactor_estree_tokens_move_json-related_code_into_subdirectory to main March 1, 2026 17:20
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
@graphite-app graphite-app bot merged commit b2b7a64 into main Mar 1, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/03-01-docs_estree_tokens_correct_comment branch March 1, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants