Skip to content

ci(benchmarks): correct comment#19650

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-23-ci_benchmarks_correct_comment
Feb 24, 2026
Merged

ci(benchmarks): correct comment#19650
graphite-app[bot] merged 1 commit intomainfrom
om/02-23-ci_benchmarks_correct_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 23, 2026

Fix a typo spotted by AI review in #19649.

Copy link
Member Author

overlookmotel commented Feb 23, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects a grammatical error in a comment within the benchmarking code for the parser. The typo was identified during an AI review of PR #19649, which added benchmarks for parsing with tokens and serializing tokens to ESTree-style JSON. The fix removes a redundant word that made the comment grammatically incorrect.

Changes:

  • Fixed grammar in comment by removing redundant "into" from "Allocate into tokens JSON into arena"

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 23, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/02-23-ci_benchmarks_correct_comment (2f5d3b6) with om/02-19-perf_parser_tokens_pre-allocate_capacity_for_tokens (b0fa937)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/02-19-perf_parser_tokens_pre-allocate_capacity_for_tokens (7dde0c1) during the generation of this report, so 67732c7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the om/02-20-perf_estree_tokens_serialize_tokens_to_compact_json branch from b87d174 to 2507a1b Compare February 23, 2026 23:47
@overlookmotel overlookmotel force-pushed the om/02-23-ci_benchmarks_correct_comment branch from afba54f to 036fe92 Compare February 23, 2026 23:47
@overlookmotel overlookmotel changed the base branch from om/02-20-perf_estree_tokens_serialize_tokens_to_compact_json to graphite-base/19650 February 23, 2026 23:57
@overlookmotel overlookmotel force-pushed the om/02-23-ci_benchmarks_correct_comment branch from 036fe92 to 156edc3 Compare February 23, 2026 23:57
@overlookmotel overlookmotel changed the base branch from graphite-base/19650 to om/02-19-perf_parser_tokens_pre-allocate_capacity_for_tokens February 23, 2026 23:58
@overlookmotel overlookmotel force-pushed the om/02-23-ci_benchmarks_correct_comment branch from 156edc3 to bf07055 Compare February 23, 2026 23:59
@graphite-app graphite-app bot force-pushed the om/02-19-perf_parser_tokens_pre-allocate_capacity_for_tokens branch from 0fb360b to 6ff9816 Compare February 24, 2026 02:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
Base automatically changed from om/02-19-perf_parser_tokens_pre-allocate_capacity_for_tokens to main February 24, 2026 13:50
@graphite-app graphite-app bot merged commit bb06e39 into main Feb 24, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/02-23-ci_benchmarks_correct_comment branch February 24, 2026 13:51
This was referenced Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants