test(estree/tokens): do not skip tokens conformance tests for files with hashbangs#19643
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Conversation
This was referenced Feb 23, 2026
Member
Author
a7750c2 to
2b10b80
Compare
077e11c to
894fc49
Compare
894fc49 to
ecec8f9
Compare
2b10b80 to
4482d2c
Compare
This was referenced Feb 23, 2026
4482d2c to
3ccbc53
Compare
ecec8f9 to
819ea8e
Compare
3ccbc53 to
c0a33ba
Compare
…ith hashbangs (#19643) We were skipping some ESTree tokens conformance tests for files containing hashbangs. We have to skip these tests for ESTree AST tests due to our non-standard `hashbang` field on `Program`, but we don't have to skip them for tokens tests - hashbangs are handled correctly.
0a46ff0 to
d56f6cd
Compare
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We were skipping some ESTree tokens conformance tests for files containing hashbangs. We have to skip these tests for ESTree AST tests due to our non-standard
hashbangfield onProgram, but we don't have to skip them for tokens tests - hashbangs are handled correctly.