Skip to content

test(estree/tokens): do not skip tokens conformance tests for files with hashbangs#19643

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs
Feb 24, 2026
Merged

test(estree/tokens): do not skip tokens conformance tests for files with hashbangs#19643
graphite-app[bot] merged 1 commit intomainfrom
om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 23, 2026

We were skipping some ESTree tokens conformance tests for files containing hashbangs. We have to skip these tests for ESTree AST tests due to our non-standard hashbang field on Program, but we don't have to skip them for tokens tests - hashbangs are handled correctly.

Copy link
Member Author

overlookmotel commented Feb 23, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Feb 23, 2026
@overlookmotel overlookmotel marked this pull request as ready for review February 23, 2026 20:38
Copilot AI review requested due to automatic review settings February 23, 2026 20:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@graphite-app graphite-app bot force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from a7750c2 to 2b10b80 Compare February 23, 2026 21:00
@graphite-app graphite-app bot force-pushed the om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs branch from 077e11c to 894fc49 Compare February 23, 2026 21:01
@overlookmotel overlookmotel force-pushed the om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs branch from 894fc49 to ecec8f9 Compare February 23, 2026 22:05
@overlookmotel overlookmotel force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from 2b10b80 to 4482d2c Compare February 23, 2026 22:05
@graphite-app graphite-app bot force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from 4482d2c to 3ccbc53 Compare February 24, 2026 02:44
@graphite-app graphite-app bot force-pushed the om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs branch from ecec8f9 to 819ea8e Compare February 24, 2026 02:44
@graphite-app graphite-app bot force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from 3ccbc53 to c0a33ba Compare February 24, 2026 03:05
…ith hashbangs (#19643)

We were skipping some ESTree tokens conformance tests for files containing hashbangs. We have to skip these tests for ESTree AST tests due to our non-standard `hashbang` field on `Program`, but we don't have to skip them for tokens tests - hashbangs are handled correctly.
@graphite-app graphite-app bot force-pushed the om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs branch from 0a46ff0 to d56f6cd Compare February 24, 2026 10:09
@graphite-app graphite-app bot merged commit d56f6cd into main Feb 24, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/02-23-test_estree_tokens_do_not_skip_tokens_conformance_tests_for_files_with_hashbangs branch February 24, 2026 10:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
This was referenced Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants