test(napi/parser): fix tests for range, parent, and lazy on TS fixtures#19884
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 1, 2026
Conversation
This was referenced Mar 1, 2026
Member
Author
This was referenced Mar 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates napi/parser TypeScript fixture tests so range/parent validation and experimentalLazy deserialization are exercised per TS fixture part (unit) rather than against the entire fixture file, aligning these tests with how AST snapshot comparisons already work.
Changes:
- In
runTsCase, pass the per-unitcodetotestRangeParentinstead of the fullsourceText. - In
runTsCase, pass the per-unitcodetotestLazyinstead of the fullsourceText.
3d9f043 to
f68d533
Compare
fe2d845 to
cd255b5
Compare
Member
Author
Merge activity
|
cd255b5 to
f53737d
Compare
f68d533 to
daaf50f
Compare
…es (#19884) `napi/parser`'s tests for raw transfer ranges, parents, and lazy deserialization were incorrect. They were testing parsing the entire TS fixture file, which can contain multiple parts, instead of testing each part individually. Fix that.
f53737d to
449080c
Compare
daaf50f to
8b89309
Compare
Base automatically changed from
om/03-01-refactor_estree_tokens_convert_token_kinds_to_estreekind_
to
main
March 1, 2026 17:48
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

napi/parser's tests for raw transfer ranges, parents, and lazy deserialization were incorrect. They were testing parsing the entire TS fixture file, which can contain multiple parts, instead of testing each part individually. Fix that.