refactor(estree/tokens): re-order code#19837
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
This was referenced Feb 28, 2026
This was referenced Feb 28, 2026
Member
Author
This was referenced Feb 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxc_estree_tokens’s main module layout by re-ordering items so the public API (options + serialization entrypoints) appears at the top of the file, without changing behavior.
Changes:
- Moved
ESTreeTokenOptions(and its preset constructors) near the top oflib.rs. - Moved
to_estree_tokens_jsonandto_estree_tokens_pretty_jsonnear the top oflib.rs.
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
Merge activity
|
9781dfa to
ba553f1
Compare
0f666d6 to
7a9d19e
Compare
Pure refactor. Re-order code so that public types and methods are at the top of the file.
ba553f1 to
0399311
Compare
7a9d19e to
04c4284
Compare
Base automatically changed from
om/02-28-docs_estree_tokens_improve_comments
to
main
February 28, 2026 13:08
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Re-order code so that public types and methods are at the top of the file.