Skip to content

refactor(estree/tokens): re-order code#19837

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_re-order_code
Feb 28, 2026
Merged

refactor(estree/tokens): re-order code#19837
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_re-order_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 28, 2026

Pure refactor. Re-order code so that public types and methods are at the top of the file.

Copy link
Member Author

overlookmotel commented Feb 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 28, 2026 12:36
Copilot AI review requested due to automatic review settings February 28, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors oxc_estree_tokens’s main module layout by re-ordering items so the public API (options + serialization entrypoints) appears at the top of the file, without changing behavior.

Changes:

  • Moved ESTreeTokenOptions (and its preset constructors) near the top of lib.rs.
  • Moved to_estree_tokens_json and to_estree_tokens_pretty_json near the top of lib.rs.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/02-28-refactor_estree_tokens_re-order_code (0f666d6) with om/02-28-docs_estree_tokens_improve_comments (9781dfa)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel added A-parser Area - Parser A-linter-plugins Area - Linter JS plugins labels Feb 28, 2026
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 28, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 28, 2026

Merge activity

@overlookmotel overlookmotel force-pushed the om/02-28-docs_estree_tokens_improve_comments branch from 9781dfa to ba553f1 Compare February 28, 2026 12:59
@overlookmotel overlookmotel force-pushed the om/02-28-refactor_estree_tokens_re-order_code branch from 0f666d6 to 7a9d19e Compare February 28, 2026 12:59
Pure refactor. Re-order code so that public types and methods are at the top of the file.
@graphite-app graphite-app bot force-pushed the om/02-28-docs_estree_tokens_improve_comments branch from ba553f1 to 0399311 Compare February 28, 2026 13:01
@graphite-app graphite-app bot requested a review from camc314 as a code owner February 28, 2026 13:01
@graphite-app graphite-app bot force-pushed the om/02-28-refactor_estree_tokens_re-order_code branch from 7a9d19e to 04c4284 Compare February 28, 2026 13:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants