Skip to content

refactor(estree/tokens): use wildcard import for AST types#19681

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-21-refactor_estree_tokens_use_wildcard_import_for_ast_types
Feb 24, 2026
Merged

refactor(estree/tokens): use wildcard import for AST types#19681
graphite-app[bot] merged 1 commit intomainfrom
om/02-21-refactor_estree_tokens_use_wildcard_import_for_ast_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 24, 2026

Pure refactor. Import AST types with a wildcard use oxc_ast::ast::* instead of a massive list of types.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 24, 2026
Copy link
Member Author

overlookmotel commented Feb 24, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the import statement in crates/oxc_estree_tokens/src/lib.rs to use a wildcard import for AST types from oxc_ast::ast instead of explicitly listing 14 individual type names. This aligns with the well-established convention throughout the oxc codebase where files with extensive AST type usage prefer wildcard imports over long explicit import lists.

Changes:

  • Replaced explicit import list of 14 AST types with use oxc_ast::ast::*

@overlookmotel overlookmotel self-assigned this Feb 24, 2026
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Feb 24, 2026
@graphite-app graphite-app bot force-pushed the om/02-21-refactor_estree_tokens_use_wildcard_import_for_ast_types branch from 2bb84fd to f5b3a8a Compare February 24, 2026 15:51
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 24, 2026

Merge activity

Pure refactor. Import AST types with a wildcard `use oxc_ast::ast::*` instead of a massive list of types.
@graphite-app graphite-app bot force-pushed the om/02-24-test_estree_estree_conformance_check_files_with_hashbangs branch from b3afc39 to 3569aab Compare February 24, 2026 16:04
@graphite-app graphite-app bot force-pushed the om/02-21-refactor_estree_tokens_use_wildcard_import_for_ast_types branch from f5b3a8a to 0bdfc0e Compare February 24, 2026 16:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
Base automatically changed from om/02-24-test_estree_estree_conformance_check_files_with_hashbangs to main February 24, 2026 16:11
@graphite-app graphite-app bot merged commit 0bdfc0e into main Feb 24, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/02-21-refactor_estree_tokens_use_wildcard_import_for_ast_types branch February 24, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants