Skip to content

fix(estree): fix tokens for JSX#19524

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-18-fix_estree_fix_tokens_for_jsx
Feb 24, 2026
Merged

fix(estree): fix tokens for JSX#19524
graphite-app[bot] merged 1 commit intomainfrom
om/02-18-fix_estree_fix_tokens_for_jsx

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 18, 2026

Fix tokens when parsing JSX (not TSX) so they match acorn-jsx test cases. TS-ESLint's tokens are clearly wrong. We continue to match TS-ESLint bug-for-bug, but process plain JSX differently, so both the TS and JSX tests pass.

The only 2 remaining failing JSX test cases are due to #9667. Both these cases are also failing in the ESTree AST conformance tests.

Copy link
Member Author

overlookmotel commented Feb 18, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/02-18-fix_estree_fix_tokens_for_jsx (e7112a6) with main (b3b2d30)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from de8e0f2 to b72bfc0 Compare February 20, 2026 10:07
@overlookmotel overlookmotel force-pushed the c/02-17-feat_parser_estree_coverage_add_parser_tokens_and_shared_estree_conversion branch 2 times, most recently from 74692a5 to c30efe0 Compare February 20, 2026 11:42
@overlookmotel overlookmotel force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from b72bfc0 to 80908e1 Compare February 20, 2026 11:42
@overlookmotel overlookmotel changed the base branch from c/02-17-feat_parser_estree_coverage_add_parser_tokens_and_shared_estree_conversion to graphite-base/19524 February 23, 2026 15:33
@overlookmotel overlookmotel force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from 80908e1 to 3ba19b5 Compare February 23, 2026 15:33
@overlookmotel overlookmotel changed the base branch from graphite-base/19524 to om/02-23-perf_parser_introduce_parserconfig_ February 23, 2026 16:10
@overlookmotel overlookmotel changed the base branch from om/02-23-perf_parser_introduce_parserconfig_ to graphite-base/19524 February 23, 2026 16:49
@overlookmotel overlookmotel force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from 3ba19b5 to fc2337d Compare February 23, 2026 18:13
@overlookmotel overlookmotel changed the base branch from graphite-base/19524 to om/02-23-perf_parser_introduce_parserconfig_ February 23, 2026 18:13
@overlookmotel overlookmotel marked this pull request as ready for review February 23, 2026 18:13
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
Copy link
Contributor

camc314 commented Feb 24, 2026

Merge activity

Fix tokens when parsing JSX (not TSX) so they match `acorn-jsx` test cases. TS-ESLint's tokens are clearly wrong. We continue to match TS-ESLint bug-for-bug, but process plain JSX differently, so both the TS and JSX tests pass.

The only 2 remaining failing JSX test cases are due to #9667. Both these cases are also failing in the ESTree AST conformance tests.
@graphite-app graphite-app bot force-pushed the om/02-18-fix_estree_fix_tokens_for_jsx branch from e7112a6 to 50a7514 Compare February 24, 2026 09:40
@graphite-app graphite-app bot merged commit 50a7514 into main Feb 24, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/02-18-fix_estree_fix_tokens_for_jsx branch February 24, 2026 09:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
@overlookmotel overlookmotel added A-parser Area - Parser A-linter-plugins Area - Linter JS plugins labels Feb 24, 2026
This was referenced Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants