fix(estree): fix tokens for JSX#19524
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This was referenced Feb 18, 2026
Member
Author
Merging this PR will not alter performance
Comparing Footnotes
|
This was referenced Feb 19, 2026
de8e0f2 to
b72bfc0
Compare
74692a5 to
c30efe0
Compare
b72bfc0 to
80908e1
Compare
c30efe0 to
a62c8da
Compare
80908e1 to
3ba19b5
Compare
a62c8da to
fcc54a9
Compare
3ba19b5 to
fc2337d
Compare
Contributor
Merge activity
|
Fix tokens when parsing JSX (not TSX) so they match `acorn-jsx` test cases. TS-ESLint's tokens are clearly wrong. We continue to match TS-ESLint bug-for-bug, but process plain JSX differently, so both the TS and JSX tests pass. The only 2 remaining failing JSX test cases are due to #9667. Both these cases are also failing in the ESTree AST conformance tests.
e7112a6 to
50a7514
Compare
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix tokens when parsing JSX (not TSX) so they match
acorn-jsxtest cases. TS-ESLint's tokens are clearly wrong. We continue to match TS-ESLint bug-for-bug, but process plain JSX differently, so both the TS and JSX tests pass.The only 2 remaining failing JSX test cases are due to #9667. Both these cases are also failing in the ESTree AST conformance tests.