Skip to content

test(estree): ESTree conformance check files with hashbangs#19680

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-24-test_estree_estree_conformance_check_files_with_hashbangs
Feb 24, 2026
Merged

test(estree): ESTree conformance check files with hashbangs#19680
graphite-app[bot] merged 1 commit intomainfrom
om/02-24-test_estree_estree_conformance_check_files_with_hashbangs

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 24, 2026

Oxc's AST on JS side has a non-standard hashbang property. Previously in ESTree conformance tests, we skipped files with a hashbang.

Bump estree-conformance submodule to include oxc-project/estree-conformance#183 which adds hashbang property to AST in snapshots.

We can now enable the tests which we previously skipped.

Copy link
Member Author

overlookmotel commented Feb 24, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 24, 2026 15:28
Copilot AI review requested due to automatic review settings February 24, 2026 15:28
@overlookmotel overlookmotel self-assigned this Feb 24, 2026
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins A-parser Area - Parser labels Feb 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables ESTree conformance tests for files with hashbangs by updating the estree-conformance submodule to include support for Oxc's non-standard hashbang property in the AST. Previously, these tests were skipped because the snapshots didn't include the hashbang field, causing mismatches.

Changes:

  • Removed skip logic for hashbang tests in test262 and TypeScript ESTree conformance tests
  • Updated estree-conformance submodule to commit 49d5664f which includes hashbang property support
  • Updated test snapshots to reflect 10 additional test262 tests and 6 additional TypeScript tests now being tested

Reviewed changes

Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tasks/coverage/src/tools.rs Removed skip conditions for test262 hashbang tests and 6 TypeScript test files with hashbangs
tasks/coverage/snapshots/estree_typescript_tokens.snap Updated test counts (9761→9767) to reflect 6 additional tests
tasks/coverage/snapshots/estree_typescript.snap Updated test counts (9761→9767) to reflect 6 additional tests
tasks/coverage/snapshots/estree_test262.snap Updated test counts (46553→46563) to reflect 10 additional tests
tasks/coverage/snapshots/estree_acorn_jsx_tokens.snap Updated commit hash to 49d5664f for estree-conformance submodule
tasks/coverage/snapshots/estree_acorn_jsx.snap Updated commit hash to 49d5664f for estree-conformance submodule
.github/scripts/clone-parallel.mjs Updated ESTREE_CONFORMANCE_SHA to 49d5664f to pull the updated submodule

@graphite-app graphite-app bot force-pushed the om/02-24-test_estree_estree_conformance_check_files_with_hashbangs branch from 26218b8 to 6872c00 Compare February 24, 2026 15:51
@graphite-app graphite-app bot changed the base branch from graphite-base/19680 to om/02-24-fix_estree_tokens_reverse_field_order_of_regex_object_in_tokens February 24, 2026 15:51
@graphite-app graphite-app bot force-pushed the om/02-24-test_estree_estree_conformance_check_files_with_hashbangs branch from 6872c00 to b3afc39 Compare February 24, 2026 15:51
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 24, 2026

Merge activity

Oxc's AST on JS side has a non-standard `hashbang` property. Previously in ESTree conformance tests, we skipped files with a hashbang.

Bump `estree-conformance` submodule to include oxc-project/estree-conformance#183 which adds `hashbang` property to AST in snapshots.

We can now enable the tests which we previously skipped.
@graphite-app graphite-app bot force-pushed the om/02-24-fix_estree_tokens_reverse_field_order_of_regex_object_in_tokens branch from 933fd15 to f5694ce Compare February 24, 2026 16:04
@graphite-app graphite-app bot requested a review from camc314 as a code owner February 24, 2026 16:04
@graphite-app graphite-app bot force-pushed the om/02-24-test_estree_estree_conformance_check_files_with_hashbangs branch from b3afc39 to 3569aab Compare February 24, 2026 16:04
Base automatically changed from om/02-24-fix_estree_tokens_reverse_field_order_of_regex_object_in_tokens to main February 24, 2026 16:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
@graphite-app graphite-app bot merged commit 3569aab into main Feb 24, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/02-24-test_estree_estree_conformance_check_files_with_hashbangs branch February 24, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants