refactor(estree/tokens): rename types#19834
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
This was referenced Feb 28, 2026
Member
Author
This was referenced Feb 28, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
a2fe057 to
13cc279
Compare
a50f5e9 to
5b6c17d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the oxc_estree_tokens crate to use consistent ESTree* capitalization for token-related types, and updates internal/workspace call sites accordingly.
Changes:
- Renamed
EstreeTokenOptionstoESTreeTokenOptionsand updated all Rust call sites. - Renamed token serialization types (e.g.,
EstreeUnsafeToken→ESTreeUnsafeToken) and internal context/config types for consistency. - Updated token serialization entry points to accept the renamed options type.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/src/tools.rs | Updates token option type name used by coverage tooling. |
| tasks/benchmark/benches/parser.rs | Updates benchmark token serialization to use the renamed options type. |
| crates/oxc_linter/src/lib.rs | Updates linter token serialization to use the renamed options type. |
| crates/oxc_estree_tokens/src/lib.rs | Renames public token-related types and internal serializer config/context types. |
| apps/oxlint/src/js_plugins/parse.rs | Updates oxlint JS plugin parsing to use the renamed options type. |
This was referenced Feb 28, 2026
Contributor
Merge activity
|
Pure refactor. Rename types. Correct capitalization in `ESTreeSafeToken` etc.
5b6c17d to
06767ed
Compare
13cc279 to
6f676dc
Compare
Base automatically changed from
om/02-22-fix_estree_tokens_convert_this_tokens_in_tstypename_
to
main
February 28, 2026 13:05
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Rename types. Correct capitalization in
ESTreeSafeTokenetc.