Skip to content

refactor(estree/tokens): rename types#19834

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_rename_types
Feb 28, 2026
Merged

refactor(estree/tokens): rename types#19834
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_rename_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 28, 2026

Pure refactor. Rename types. Correct capitalization in ESTreeSafeToken etc.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 28, 2026
Copy link
Member Author

overlookmotel commented Feb 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/02-28-refactor_estree_tokens_rename_types (13cc279) with om/02-22-fix_estree_tokens_convert_this_tokens_in_tstypename_ (5b6c17d)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/02-28-refactor_estree_tokens_rename_types branch from a2fe057 to 13cc279 Compare February 28, 2026 12:31
@overlookmotel overlookmotel force-pushed the om/02-22-fix_estree_tokens_convert_this_tokens_in_tstypename_ branch from a50f5e9 to 5b6c17d Compare February 28, 2026 12:31
@overlookmotel overlookmotel marked this pull request as ready for review February 28, 2026 12:33
Copilot AI review requested due to automatic review settings February 28, 2026 12:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the oxc_estree_tokens crate to use consistent ESTree* capitalization for token-related types, and updates internal/workspace call sites accordingly.

Changes:

  • Renamed EstreeTokenOptions to ESTreeTokenOptions and updated all Rust call sites.
  • Renamed token serialization types (e.g., EstreeUnsafeTokenESTreeUnsafeToken) and internal context/config types for consistency.
  • Updated token serialization entry points to accept the renamed options type.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tasks/coverage/src/tools.rs Updates token option type name used by coverage tooling.
tasks/benchmark/benches/parser.rs Updates benchmark token serialization to use the renamed options type.
crates/oxc_linter/src/lib.rs Updates linter token serialization to use the renamed options type.
crates/oxc_estree_tokens/src/lib.rs Renames public token-related types and internal serializer config/context types.
apps/oxlint/src/js_plugins/parse.rs Updates oxlint JS plugin parsing to use the renamed options type.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 28, 2026

Merge activity

Pure refactor. Rename types. Correct capitalization in `ESTreeSafeToken` etc.
@graphite-app graphite-app bot force-pushed the om/02-22-fix_estree_tokens_convert_this_tokens_in_tstypename_ branch from 5b6c17d to 06767ed Compare February 28, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants