Skip to content

refactor(estree/tokens): make ESTreeUnsafeToken type private#19835

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_make_estreeunsafetoken_type_private
Feb 28, 2026
Merged

refactor(estree/tokens): make ESTreeUnsafeToken type private#19835
graphite-app[bot] merged 1 commit intomainfrom
om/02-28-refactor_estree_tokens_make_estreeunsafetoken_type_private

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 28, 2026

Pure refactor. Do not expose ESTreeUnsafeToken type publically. It's an internal type.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 28, 2026
Copy link
Member Author

overlookmotel commented Feb 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/02-28-refactor_estree_tokens_make_estreeunsafetoken_type_private (3afa959) with om/02-28-refactor_estree_tokens_rename_types (13cc279)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/02-28-refactor_estree_tokens_make_estreeunsafetoken_type_private branch from e498ad1 to 3afa959 Compare February 28, 2026 12:31
@overlookmotel overlookmotel force-pushed the om/02-28-refactor_estree_tokens_rename_types branch from a2fe057 to 13cc279 Compare February 28, 2026 12:31
@overlookmotel overlookmotel marked this pull request as ready for review February 28, 2026 12:34
Copilot AI review requested due to automatic review settings February 28, 2026 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors oxc_estree_tokens to reduce its public API surface by making ESTreeUnsafeToken an internal implementation detail.

Changes:

  • Make ESTreeUnsafeToken private (and its fields non-public) in lib.rs.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 28, 2026

Merge activity

Pure refactor. Do not expose `ESTreeUnsafeToken` type publically. It's an internal type.
@graphite-app graphite-app bot force-pushed the om/02-28-refactor_estree_tokens_rename_types branch from 13cc279 to 6f676dc Compare February 28, 2026 13:00
@graphite-app graphite-app bot requested a review from camc314 as a code owner February 28, 2026 13:00
@graphite-app graphite-app bot force-pushed the om/02-28-refactor_estree_tokens_make_estreeunsafetoken_type_private branch from 3afa959 to 0a5a2aa Compare February 28, 2026 13:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants