Skip to content

refactor(estree/tokens): move raw transfer-related files into subdirectory#19892

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory
Mar 1, 2026
Merged

refactor(estree/tokens): move raw transfer-related files into subdirectory#19892
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 1, 2026

Pure refactor. Move files related to raw transfer into their own directory, mirroring that all files related to JSON serialization have their own directory too.

Copy link
Member Author

overlookmotel commented Mar 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors oxc_estree_tokens’ raw-transfer implementation by moving ESTreeKind (the compact token-kind mapping used for JS-side raw transfer) into the raw_transfer/ submodule, aligning structure with the existing JSON serialization layout.

Changes:

  • Move ESTreeKind implementation into raw_transfer/estree_kind.rs.
  • Update raw_transfer/mod.rs to use the new internal submodule.
  • Remove the now-unneeded top-level mod estree_kind; from lib.rs.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_estree_tokens/src/raw_transfer/mod.rs Switches ESTreeKind usage to a local raw_transfer::estree_kind submodule.
crates/oxc_estree_tokens/src/raw_transfer/estree_kind.rs Houses the compact KindESTreeKind mapping and conversion utilities for raw transfer.
crates/oxc_estree_tokens/src/lib.rs Drops the old top-level estree_kind module declaration.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory (b0e8d04) with om/03-01-test_estree_tokens_add_tests_for_tokens_via_raw_transfer (be741da)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory branch from c17ff02 to b0e8d04 Compare March 1, 2026 19:39
@overlookmotel overlookmotel force-pushed the om/03-01-test_estree_tokens_add_tests_for_tokens_via_raw_transfer branch from e594f3d to be741da Compare March 1, 2026 19:39
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
Copy link
Member Author

overlookmotel commented Mar 1, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the om/03-01-test_estree_tokens_add_tests_for_tokens_via_raw_transfer branch from be741da to 0a87dbd Compare March 1, 2026 20:00
graphite-app bot pushed a commit that referenced this pull request Mar 1, 2026
…ctory (#19892)

Pure refactor. Move files related to raw transfer into their own directory, mirroring that all files related to JSON serialization have their own directory too.
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory branch from b0e8d04 to f9f0fb7 Compare March 1, 2026 20:01
…ctory (#19892)

Pure refactor. Move files related to raw transfer into their own directory, mirroring that all files related to JSON serialization have their own directory too.
@graphite-app graphite-app bot force-pushed the om/03-01-test_estree_tokens_add_tests_for_tokens_via_raw_transfer branch from 0a87dbd to 1f9c115 Compare March 1, 2026 20:02
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory branch from f9f0fb7 to 68152f3 Compare March 1, 2026 20:03
Base automatically changed from om/03-01-test_estree_tokens_add_tests_for_tokens_via_raw_transfer to main March 1, 2026 20:09
@graphite-app graphite-app bot merged commit 68152f3 into main Mar 1, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/03-01-refactor_estree_tokens_move_raw_transfer-related_files_into_subdirectory branch March 1, 2026 20:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants