refactor(estree/tokens): shorten code

[overlookmotel]

Pure refactor. Replace repetitious code with a shared method.

[overlookmotel]

• refactor(linter/plugins): add regex field to all tokens #19894
• perf(linter/plugins): transfer tokens via raw transfer #19893
• refactor(estree/tokens): move raw transfer-related files into subdirectory #19892
• test(estree/tokens): add tests for tokens via raw transfer #19885
• test(napi/parser): fix tests for range, parent, and lazy on TS fixtures #19884
• refactor(estree/tokens): convert token kinds to ESTreeKind #19875
• feat(parser): add VARIANTS const to Kind via fieldless_enum! macro #19877
• feat(data_structures): add fieldless_enum! macro #19876
• feat(parser): make all Kind::is_* methods const #19874
• docs(estree/tokens): correct comment #19873
• refactor(estree/tokens): move JSON-related code into subdirectory #19869
• refactor(estree/tokens): shorten code #19868 👈 (View in Graphite)
• refactor(estree/tokens): add Context methods from different AST nodes #19867
• refactor(estree/tokens): rename UpdateContext to RawContext #19866
• refactor(estree/tokens): break up into multiple files #19865
• feat(estree/tokens): add function to update tokens in place #19856 : 1 other dependent PR (#19858 )
• refactor(estree/tokens): reduce repeated code #19857
• ci(benchmarks): add benchmark for updating tokens for raw transfer #19854
• feat(parser): add mutate_tokens Cargo feature #19853
• refactor(parser): Token::set_* method visible only within lexer #19852
• perf(estree/tokens): preallocate sufficient space for tokens JSON #19851
• refactor(estree/tokens): break up into multiple files #19850
• perf(estree/tokens): introduce ESTreeTokenConfig trait #19842
• refactor(estree/tokens): move logic for JSX identifiers into JSXState struct #19839
• fix(linter/plugins): decode escapes in identifier tokens #19838
• refactor(estree/tokens): re-order code #19837
• docs(estree/tokens): improve comments #19836
• refactor(estree/tokens): make ESTreeUnsafeToken type private #19835
• refactor(estree/tokens): rename types #19834
• fix(estree/tokens): convert this tokens in TSTypeName #19815
• perf(estree/tokens): do not JSON-encode keyword, punctuator, etc tokens #19814
• perf(estree/tokens): do not JSON-encode this identifiers #19813
• perf(estree/tokens): do not JSON-encode JSX identifiers #19812
• perf(estree/tokens): handle regex tokens separately #19796
• perf(estree/tokens): use strings from AST for identifier tokens #19744 : 1 other dependent PR (#19735 )
• refactor(estree/tokens): add TokenType type #19789
• feat(estree): add IS_COMPACT const to Formatter trait #19787
• feat(estree): expose buffer and formatter of serializers #19773
• perf(estree): use CodeBuffer::print_strs_array to reduce bounds checks #19766
• feat(data_structures): add CodeBuffer::print_strs_array #19760
• perf(estree): use CodeBuffer::print_indent #19727
• perf(estree/tokens): serialize tokens while visiting AST #19726
• perf(estree/tokens): serialize with ESTree not serde #19725
• feat(estree): oxc_estree crate export config and formatter types #19724
• refactor(estree/tokens): convert tokens spans before AST spans #19723
• refactor(estree/tokens): simplify code #19722
• perf(estree/tokens): do not branch on presence of override twice #19721
• refactor(estree/tokens): move logic for excluding legacy identifiers into visitor #19720
• perf(estree/tokens): replace hash map with Vec #19718
• perf(estree/tokens): replace multiple hash sets into a single hash map #19716
• refactor(estree/tokens): replace stored token when re-lexing #19698
• perf(parser): remove branches from finish_next_inner #19695
• perf(parser): remove const generic param from finish_next_inner #19684
• feat(parser): add LexerConfig::TOKENS_METHOD_IS_STATIC const #19683
• docs(parser): improve doc comments for ParserConfig and LexerConfig #19682
• refactor(estree/tokens): use wildcard import for AST types #19681
• test(estree): ESTree conformance check files with hashbangs #19680
• fix(estree/tokens): reverse field order of regex object in tokens #19679
• perf(estree/tokens): serialize tokens to compact JSON #19572
• ci(benchmarks): correct comment #19650
• perf(parser/tokens): pre-allocate capacity for tokens #19543
• fix(estree/tokens): generate tokens for files with BOM #19535
• refactor(estree/tokens): combine collect_token_context into to_estree_tokens_json #19534
• refactor(estree): reorder tokens code #19533
• refactor(coverage): standardize ESTree tokens testing functions #19532
• perf(linter/plugins): remove typescript from bundle #19531
• docs(linter/plugins): correct doc comments for initTokens #19530
• refactor(linter/plugins): combine functions for getting tokens #19529
• ci(benchmarks): benchmark parser with tokens and ESTree tokens conversion #19649
• perf(linter/plugins): use Oxc tokens in plugins #19498
• test(estree/tokens): do not skip tokens conformance tests for files with hashbangs #19643
• fix(estree): fix tokens for JSX #19524
• perf(parser): introduce ParserConfig #19637
• feat(parser,estree,coverage): collect tokens in parser and convert to ESTree format #19497
• feat(coverage): add estree token conformance scaffolding #19496
• fix(tasks/coverage): bring back acorn-jsx estree testing #19516 : 1 other dependent PR (#19515 )
• chore(submodules): update submodule SHAs to latest commits #19518
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors RawContext’s token-kind mutation logic by extracting repeated “advance to token and set kind” code into a shared helper, keeping behavior the same while reducing duplication.

Changes:

• Add a RawContext::set_kind_at(start, kind) helper to centralize “advance + set kind”.
• Update emit_this_identifier_at, emit_jsx_identifier_at, and emit_string_literal_as_jsx_text to use the new helper.

[codspeed-hq]

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing om/03-01-refactor_estree_tokens_shorten_code (13e7557) with om/03-01-refactor_estree_tokens_make_context_methods_take_ast_nodes (c919ce9)}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Mar 1, 5:06 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Mar 1, 5:13 PM UTC: Merged by the Graphite merge queue.