Skip to content

refactor(linter/plugins): combine functions for getting tokens#19529

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens
Feb 24, 2026
Merged

refactor(linter/plugins): combine functions for getting tokens#19529
graphite-app[bot] merged 1 commit intomainfrom
om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 19, 2026

Refactor. Logic related to tokens was spread across 2 files. Move it all into tokens.ts.

Also, fix one small bug where there'd be an error when linting an empty file.

Copy link
Member Author

overlookmotel commented Feb 19, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Feb 19, 2026
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 19, 2026
@overlookmotel overlookmotel changed the base branch from c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback to graphite-base/19529 February 20, 2026 10:07
@overlookmotel overlookmotel force-pushed the om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens branch from e4b44ef to 02d9450 Compare February 20, 2026 10:08
@overlookmotel overlookmotel changed the base branch from graphite-base/19529 to c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback February 20, 2026 10:08
@overlookmotel overlookmotel changed the base branch from c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback to graphite-base/19529 February 20, 2026 11:42
@overlookmotel overlookmotel force-pushed the om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens branch from 02d9450 to d07e4ea Compare February 20, 2026 11:43
@overlookmotel overlookmotel changed the base branch from graphite-base/19529 to c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback February 20, 2026 11:43
@overlookmotel overlookmotel force-pushed the c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback branch from 40e3999 to f0c4c4b Compare February 23, 2026 16:10
@overlookmotel overlookmotel force-pushed the om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens branch from d07e4ea to b5c19dc Compare February 23, 2026 16:10
@overlookmotel overlookmotel changed the base branch from c/02-17-feat_oxlint_integrate_shared_estree_tokens_and_remove_ts_fallback to graphite-base/19529 February 23, 2026 20:29
Base automatically changed from om/02-23-ci_benchmarks_benchmark_parser_with_tokens_and_estree_tokens_conversion to main February 24, 2026 11:38
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 24, 2026
@graphite-app graphite-app bot merged commit 5ca0d9a into main Feb 24, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/02-18-refactor_linter_plugins_combine_functions_for_getting_tokens branch February 24, 2026 11:39
This was referenced Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants