Skip to content

perf(estree): use CodeBuffer::print_strs_array to reduce bounds checks#19766

Draft
overlookmotel wants to merge 1 commit intoom/02-26-feat_data_structures_add_codebuffer_print_strs_array_from
om/02-26-perf_estree_use_codebuffer_print_strs_array_to_reduce_bounds_checks
Draft

perf(estree): use CodeBuffer::print_strs_array to reduce bounds checks#19766
overlookmotel wants to merge 1 commit intoom/02-26-feat_data_structures_add_codebuffer_print_strs_array_from
om/02-26-perf_estree_use_codebuffer_print_strs_array_to_reduce_bounds_checks

Conversation

@overlookmotel
Copy link
Member

No description provided.

Copy link
Member Author

overlookmotel commented Feb 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Feb 26, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will improve performance by 10.48%

⚡ 2 improved benchmarks
✅ 50 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation estree_tokens[checker.ts] 147.6 ms 137.8 ms +7.05%
Simulation estree[checker.ts] 105.6 ms 95.6 ms +10.48%

Comparing om/02-26-perf_estree_use_codebuffer_print_strs_array_to_reduce_bounds_checks (be57855) with om/02-26-feat_data_structures_add_codebuffer_print_strs_array_ (4add9b5)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel self-assigned this Feb 26, 2026
@overlookmotel overlookmotel added A-parser Area - Parser A-linter-plugins Area - Linter JS plugins labels Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant