refactor(estree/tokens): add TokenType type

[overlookmotel]

Refactor. Add a TokenType type which represents the type of a token. It's purely a wrapper around a &'static str, except that it enforces a maximum length on the string.

This invariant is used in #19744 to avoid overflow checks when calling CodeBuffer::print_strs_array.

[overlookmotel]

• perf(estree/tokens): use strings from AST for identifier tokens #19744 : 2 dependent PRs (#19735 , #19796 )
• refactor(estree/tokens): add TokenType type #19789 👈 (View in Graphite)
• feat(estree): add IS_COMPACT const to Formatter trait #19787
• feat(estree): expose buffer and formatter of serializers #19773
• perf(estree): use CodeBuffer::print_strs_array to reduce bounds checks #19766
• feat(data_structures): add CodeBuffer::print_strs_array #19760
• perf(estree): use CodeBuffer::print_indent #19727
• perf(estree/tokens): serialize tokens while visiting AST #19726
• perf(estree/tokens): serialize with ESTree not serde #19725
• feat(estree): oxc_estree crate export config and formatter types #19724
• refactor(estree/tokens): convert tokens spans before AST spans #19723
• refactor(estree/tokens): simplify code #19722
• perf(estree/tokens): do not branch on presence of override twice #19721
• refactor(estree/tokens): move logic for excluding legacy identifiers into visitor #19720
• perf(estree/tokens): replace hash map with Vec #19718
• perf(estree/tokens): replace multiple hash sets into a single hash map #19716
• refactor(estree/tokens): replace stored token when re-lexing #19698
• perf(parser): remove branches from finish_next_inner #19695
• perf(parser): remove const generic param from finish_next_inner #19684
• feat(parser): add LexerConfig::TOKENS_METHOD_IS_STATIC const #19683
• docs(parser): improve doc comments for ParserConfig and LexerConfig #19682
• refactor(estree/tokens): use wildcard import for AST types #19681
• test(estree): ESTree conformance check files with hashbangs #19680
• fix(estree/tokens): reverse field order of regex object in tokens #19679
• perf(estree/tokens): serialize tokens to compact JSON #19572
• ci(benchmarks): correct comment #19650
• perf(parser/tokens): pre-allocate capacity for tokens #19543
• fix(estree/tokens): generate tokens for files with BOM #19535
• refactor(estree/tokens): combine collect_token_context into to_estree_tokens_json #19534
• refactor(estree): reorder tokens code #19533
• refactor(coverage): standardize ESTree tokens testing functions #19532
• perf(linter/plugins): remove typescript from bundle #19531
• docs(linter/plugins): correct doc comments for initTokens #19530
• refactor(linter/plugins): combine functions for getting tokens #19529
• ci(benchmarks): benchmark parser with tokens and ESTree tokens conversion #19649
• perf(linter/plugins): use Oxc tokens in plugins #19498
• test(estree/tokens): do not skip tokens conformance tests for files with hashbangs #19643
• fix(estree): fix tokens for JSX #19524
• perf(parser): introduce ParserConfig #19637
• feat(parser,estree,coverage): collect tokens in parser and convert to ESTree format #19497
• feat(coverage): add estree token conformance scaffolding #19496
• fix(tasks/coverage): bring back acorn-jsx estree testing #19516 : 1 other dependent PR (#19515 )
• chore(submodules): update submodule SHAs to latest commits #19518
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing om/02-26-refactor_estree_tokens_add_tokentype_type (576c090) with om/02-26-feat_estree_add_is_compact_const_to_formatter_trait (d55eb11)}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR introduces a type-safe wrapper TokenType around &'static str for token types in the ESTree token serialization code. The wrapper enforces a maximum string length of 17 characters (the length of "PrivateIdentifier" and "RegularExpression"), which enables downstream optimizations in #19744 by allowing the compiler to eliminate overflow checks when concatenating multiple strings.

Changes:

• Added TokenType struct with compile-time length validation
• Updated all token type usages to use TokenType::new() instead of raw string literals
• Added dependency on oxc_data_structures for the assert_unchecked macro

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_estree_tokens/src/lib.rs	Introduces TokenType wrapper type with length validation, updates all token type references to use the new type
crates/oxc_estree_tokens/Cargo.toml	Adds oxc_data_structures dependency with assert_unchecked feature
Cargo.lock	Updates lock file to reflect new dependency

[overlookmotel]

Merge activity

• Feb 26, 11:43 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 27, 12:10 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Feb 27, 12:18 AM UTC: Merged by the Graphite merge queue.