Skip to content

refactor(estree/tokens): rename UpdateContext to RawContext#19866

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_
Mar 1, 2026
Merged

refactor(estree/tokens): rename UpdateContext to RawContext#19866
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 1, 2026

Pure refactor. Rename UpdateContext to RawContext, and update references in comments.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 1, 2026
Copy link
Member Author

overlookmotel commented Mar 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 1, 2026 09:59
Copilot AI review requested due to automatic review settings March 1, 2026 09:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors oxc_estree_tokens’ raw-transfer token processing context by renaming UpdateContext to RawContext, updating in-code documentation to match the new terminology.

Changes:

  • Rename UpdateContext to RawContext in the raw transfer implementation.
  • Update doc/comments to replace “update mode” phrasing with “raw transfer mode”.
  • Minor wording improvements in docs (e.g., “update” → “set”) to better describe behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/oxc_estree_tokens/src/visitor.rs Updates “update mode” comment wording to “raw transfer mode” in visitor notes.
crates/oxc_estree_tokens/src/raw_transfer.rs Renames UpdateContextRawContext and updates related doc comments.
crates/oxc_estree_tokens/src/lib.rs Updates crate-level docs to reference RawContext.
crates/oxc_estree_tokens/src/json.rs Updates JSXState accessor docs to remove “serializer/updater” phrasing.
crates/oxc_estree_tokens/src/context.rs Updates mode terminology and doc links from UpdateContext to RawContext.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_ (b6f81a4) with om/03-01-refactor_estree_tokens_break_up_into_multiple_files (8581850)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/03-01-refactor_estree_tokens_break_up_into_multiple_files (43875e0) during the generation of this report, so 9bff91a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 1, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_break_up_into_multiple_files branch from 43875e0 to 53af931 Compare March 1, 2026 16:45
graphite-app bot pushed a commit that referenced this pull request Mar 1, 2026
Pure refactor. Rename `UpdateContext` to `RawContext`, and update references in comments.
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_ branch from b6f81a4 to 73aa87e Compare March 1, 2026 16:46
Pure refactor. Rename `UpdateContext` to `RawContext`, and update references in comments.
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_break_up_into_multiple_files branch from 53af931 to 442b0b9 Compare March 1, 2026 16:49
@graphite-app graphite-app bot force-pushed the om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_ branch from 73aa87e to bb87d80 Compare March 1, 2026 16:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
Base automatically changed from om/03-01-refactor_estree_tokens_break_up_into_multiple_files to main March 1, 2026 16:56
@graphite-app graphite-app bot merged commit bb87d80 into main Mar 1, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_ branch March 1, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants