perf(parser/tokens): pre-allocate capacity for tokens#19543
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This was referenced Feb 19, 2026
Member
Author
This was referenced Feb 19, 2026
Merging this PR will improve performance by 22.2%
Performance Changes
Comparing Footnotes
|
6cd4d00 to
5873776
Compare
cd4ce15 to
110cf79
Compare
5873776 to
9a5717b
Compare
110cf79 to
443d906
Compare
443d906 to
a4e8469
Compare
9a5717b to
8afb7c5
Compare
This was referenced Feb 23, 2026
a4e8469 to
784c267
Compare
7dde0c1 to
b83934c
Compare
Contributor
Merge activity
|
Perf optimization to parsing with tokens. Pre-allocate sufficient capacity in the `ArenaVec<Token>` so it doesn't need to grow during the parsing process. Up to 22% perf improvement on benchmarks for parsing with tokens.
d75cd3c to
b2b7a55
Compare
b83934c to
136e39b
Compare
Base automatically changed from
om/02-18-fix_estree_tokens_generate_tokens_for_files_with_bom
to
main
February 24, 2026 13:49
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Perf optimization to parsing with tokens. Pre-allocate sufficient capacity in the
ArenaVec<Token>so it doesn't need to grow during the parsing process.Up to 22% perf improvement on benchmarks for parsing with tokens.