Skip to content

chore(submodules): upgrade estree-conformance to latest SHA#19515

Closed
camc314 wants to merge 1 commit intoc/02-18-fix_tasks_coverage_bring_back_acorn-jsx_estree_testingfrom
c/02-18-chore_submodules_upgrade_estree-conformance_to_latest_sha
Closed

chore(submodules): upgrade estree-conformance to latest SHA#19515
camc314 wants to merge 1 commit intoc/02-18-fix_tasks_coverage_bring_back_acorn-jsx_estree_testingfrom
c/02-18-chore_submodules_upgrade_estree-conformance_to_latest_sha

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 18, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 18, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 18, 2026
@camc314 camc314 marked this pull request as ready for review February 18, 2026 09:51
@camc314 camc314 requested review from Copilot and removed request for Copilot February 18, 2026 09:51
@camc314 camc314 force-pushed the c/02-18-chore_submodules_upgrade_estree-conformance_to_latest_sha branch from 99f967f to 613bbc3 Compare February 18, 2026 09:56
@camc314 camc314 changed the base branch from main to graphite-base/19515 February 18, 2026 10:12
@camc314 camc314 force-pushed the c/02-18-chore_submodules_upgrade_estree-conformance_to_latest_sha branch from 613bbc3 to d3cfe93 Compare February 18, 2026 10:12
Copilot AI review requested due to automatic review settings February 18, 2026 10:12
@camc314 camc314 changed the base branch from graphite-base/19515 to c/02-18-fix_tasks_coverage_bring_back_acorn-jsx_estree_testing February 18, 2026 10:12
@camc314 camc314 force-pushed the c/02-18-chore_submodules_upgrade_estree-conformance_to_latest_sha branch from d3cfe93 to 57bd058 Compare February 18, 2026 10:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned oxc-project/estree-conformance revision and refreshes ESTree conformance coverage snapshots to reflect the new baseline.

Changes:

  • Bump ESTREE_CONFORMANCE_SHA in the parallel submodule-clone helper script.
  • Update TypeScript ESTree coverage snapshot totals and mismatch allowlist.
  • Update Test262 ESTree coverage snapshot totals and mismatch allowlist.

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.

File Description
tasks/coverage/snapshots/estree_typescript.snap Refreshes ESTree-vs-TypeScript snapshot stats and mismatch list.
tasks/coverage/snapshots/estree_test262.snap Refreshes ESTree-vs-Test262 snapshot stats and mismatch list.
.github/scripts/clone-parallel.mjs Updates the pinned estree-conformance commit SHA used by CI/scripts.

const TYPESCRIPT_SHA = "95e3aaa90341b516e868bf2300b1da5d07103f1e";
const PRETTIER_SHA = "812a4d0071270f61a7aa549d625b618be7e09d71";
const ESTREE_CONFORMANCE_SHA = "32501475c99fc022a93c80bc6ce1a607f21ecc66";
const ESTREE_CONFORMANCE_SHA = "a12445bbce745fc422d83cf9da23a6c47950f252";
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESTREE_CONFORMANCE_SHA is bumped here, but tasks/coverage/snapshots/estree_acorn_jsx.snap still has commit: 32501475 (old estree-conformance short SHA). Snapshot::save asserts when the snapshot file’s commit: header doesn’t match the checked-out repo SHA, so this will fail unless that snapshot header is updated/regenerated for the new estree-conformance commit.

Suggested change
const ESTREE_CONFORMANCE_SHA = "a12445bbce745fc422d83cf9da23a6c47950f252";
const ESTREE_CONFORMANCE_SHA = "32501475";

Copilot uses AI. Check for mistakes.
This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants