feat(data_structures): add fieldless_enum! macro#19876
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 1, 2026
Merged
feat(data_structures): add fieldless_enum! macro#19876graphite-app[bot] merged 1 commit intomainfrom
fieldless_enum! macro#19876graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Mar 1, 2026
Member
Author
Merging this PR will improve performance by 55.06%
Performance Changes
Comparing 
Footnotes
|
overlookmotel
changed the base branch from
om/03-01-refactor_estree_tokens_convert_token_kinds_to_estreekind_
to
graphite-base/19876
overlookmotel
force-pushed
the
om/03-01-feat_data_structures_add_fieldless_enum_macro
branch
from
0442a25 to
b270112
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new optional fieldless_enum! macro to oxc_data_structures (behind a feature flag) to generate fieldless enums that expose a const VARIANTS array of all variants, enabling const-context iteration-like behavior.
Changes:
- Introduces
fieldless_enum!macro and unit tests under a newfieldless_enumfeature. - Exposes the new module behind
cfg(feature = "fieldless_enum")and wires the feature into the crate’sallfeature set. - Documents the capability in the crate README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_data_structures/src/lib.rs | Feature-gated export of the new fieldless_enum module. |
| crates/oxc_data_structures/src/fieldless_enum.rs | Implements and exports the fieldless_enum! macro + tests. |
| crates/oxc_data_structures/README.md | Adds the macro to the “Key Features” list. |
| crates/oxc_data_structures/Cargo.toml | Adds the fieldless_enum feature and includes it in all. |
overlookmotel
changed the base branch from
graphite-base/19876
to
om/03-01-feat_parser_make_all_kind_is__methods_const_
This was referenced Mar 1, 2026
overlookmotel
changed the base branch from
om/03-01-feat_parser_make_all_kind_is__methods_const_
to
graphite-base/19876
overlookmotel
force-pushed
the
om/03-01-feat_data_structures_add_fieldless_enum_macro
branch
from
b270112 to
9715ef3
Compare
overlookmotel
force-pushed
the
graphite-base/19876
branch
from
9bd68f7 to
12b841e
Compare
overlookmotel
force-pushed
the
om/03-01-feat_data_structures_add_fieldless_enum_macro
branch
from
9715ef3 to
904602d
Compare
Contributor
Merge activity
|
Add a `fieldless_enum!` macro. This macro generates a `VARIANTS` constant on the type that lists all the enum's variants.
```rs
fieldless_enum! {
enum Foo {
A,
B,
C,
}
}
assert_eq!(Foo::VARIANTS, [Foo::A, Foo::B, Foo::C]);
```
This is useful for code which interacts with the enum, and needs to take some action on each variant.
graphite-app
bot
force-pushed
the
om/03-01-feat_data_structures_add_fieldless_enum_macro
branch
from
904602d to
b3dceae
Compare
graphite-app
bot
deleted the
om/03-01-feat_data_structures_add_fieldless_enum_macro
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
fieldless_enum!macro. This macro generates aVARIANTSconstant on the type that lists all the enum's variants.This is useful for code which interacts with the enum, and needs to take some action on each variant.