Skip to content

ci(benchmarks): add benchmark for updating tokens for raw transfer#19854

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer
Mar 1, 2026
Merged

ci(benchmarks): add benchmark for updating tokens for raw transfer#19854
graphite-app[bot] merged 1 commit intomainfrom
om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 28, 2026

Add a benchmark for preparing tokens on Rust side to be sent to JS with raw transfer. This isn't implemented yet, so initially this benchmark measures perf of serializing to JSON.

Copy link
Member Author

overlookmotel commented Feb 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel self-assigned this Feb 28, 2026
@overlookmotel overlookmotel added A-parser Area - Parser A-linter-plugins Area - Linter JS plugins labels Feb 28, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
🆕 1 new benchmark
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation estree_tokens_raw[checker.ts] N/A 82.9 ms N/A

Comparing om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer (efbb82b) with main (f78e6df)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/02-24-feat_parser_add_mutate_tokens_cargo_feature branch from 358f70b to 9022536 Compare February 28, 2026 16:07
@overlookmotel overlookmotel force-pushed the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch from 2657a51 to 11c2f82 Compare February 28, 2026 16:07
@overlookmotel overlookmotel changed the base branch from om/02-24-feat_parser_add_mutate_tokens_cargo_feature to graphite-base/19854 February 28, 2026 16:46
@overlookmotel overlookmotel force-pushed the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch from 11c2f82 to 94e1c0a Compare February 28, 2026 16:46
@overlookmotel overlookmotel changed the base branch from graphite-base/19854 to om/02-24-feat_parser_add_mutate_tokens_cargo_feature February 28, 2026 16:47
@overlookmotel overlookmotel force-pushed the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch from 94e1c0a to 4bd423a Compare February 28, 2026 16:48
@graphite-app graphite-app bot changed the base branch from om/02-24-feat_parser_add_mutate_tokens_cargo_feature to graphite-base/19854 February 28, 2026 17:02
@graphite-app graphite-app bot force-pushed the graphite-base/19854 branch from 45f9af2 to f78e6df Compare February 28, 2026 17:11
@graphite-app graphite-app bot force-pushed the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch from e6e6df3 to efbb82b Compare February 28, 2026 17:11
@overlookmotel overlookmotel marked this pull request as ready for review March 1, 2026 07:00
Copilot AI review requested due to automatic review settings March 1, 2026 07:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Criterion benchmark to track performance of preparing tokens for an eventual “raw transfer” path from Rust to JS; for now it benchmarks the current JSON serialization approach to establish a baseline.

Changes:

  • Introduce bench_estree_tokens_raw benchmark group for token preparation/serialization.
  • Register the new benchmark in the criterion_group! for the parser benchmarks.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 1, 2026

Merge activity

…19854)

Add a benchmark for preparing tokens on Rust side to be sent to JS with raw transfer. This isn't implemented yet, so initially this benchmark measures perf of serializing to JSON.
@graphite-app graphite-app bot force-pushed the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch from efbb82b to c4852cd Compare March 1, 2026 08:04
@graphite-app graphite-app bot merged commit c4852cd into main Mar 1, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/02-24-ci_benchmarks_add_benchmark_for_updating_tokens_for_raw_transfer branch March 1, 2026 08:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants