feat(parser): add LexerConfig::TOKENS_METHOD_IS_STATIC const#19683
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
This was referenced Feb 24, 2026
This was referenced Feb 24, 2026
This was referenced Feb 24, 2026
Member
Author
This was referenced Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new compile-time hint to LexerConfig to indicate whether tokens() is type-static vs runtime-dependent, enabling future optimizations in the parser/lexer pipeline.
Changes:
- Introduce
LexerConfig::TOKENS_METHOD_IS_STATICassociated const. - Implement the const for the built-in lexer configs (
NoTokensLexerConfig,TokensLexerConfig,RuntimeLexerConfig).
Merging this PR will not alter performance
Comparing Footnotes
|
Member
Author
Merge activity
|
Add a const to `LexerConfig` trait indicating whether the config is static or runtime. This will be useful optimization in a later PR.
4e5322b to
75c9cd8
Compare
462d3c1 to
ea6b796
Compare
Base automatically changed from
om/02-24-docs_parser_improve_doc_comments_for_parserconfig_and_lexerconfig_
to
main
February 24, 2026 16:13
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add a const to
LexerConfigtrait indicating whether the config is static or runtime. This will be useful optimization in a later PR.